| From 365f9b18a5f32204c337974c8fa58d641ac19c0a Mon Sep 17 00:00:00 2001 |
| From: Colin Ian King <colin.king@canonical.com> |
| Date: Sun, 26 Jan 2020 22:05:49 +0000 |
| Subject: [PATCH] staging: rtl8723bs: fix copy of overlapping memory |
| |
| commit 8ae9a588ca35eb9c32dc03299c5e1f4a1e9a9617 upstream. |
| |
| Currently the rtw_sprintf prints the contents of thread_name |
| onto thread_name and this can lead to a potential copy of a |
| string over itself. Avoid this by printing the literal string RTWHALXT |
| instread of the contents of thread_name. |
| |
| Addresses-Coverity: ("copy of overlapping memory") |
| Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") |
| Signed-off-by: Colin Ian King <colin.king@canonical.com> |
| Reviewed-by: Hans de Goede <hdegoede@redhat.com> |
| Link: https://lore.kernel.org/r/20200126220549.9849-1-colin.king@canonical.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c |
| index 7b06aab04ee6..a6a246dcb52a 100644 |
| --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c |
| +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c |
| @@ -477,14 +477,13 @@ int rtl8723bs_xmit_thread(void *context) |
| s32 ret; |
| struct adapter *padapter; |
| struct xmit_priv *pxmitpriv; |
| - u8 thread_name[20] = "RTWHALXT"; |
| - |
| + u8 thread_name[20]; |
| |
| ret = _SUCCESS; |
| padapter = context; |
| pxmitpriv = &padapter->xmitpriv; |
| |
| - rtw_sprintf(thread_name, 20, "%s-"ADPT_FMT, thread_name, ADPT_ARG(padapter)); |
| + rtw_sprintf(thread_name, 20, "RTWHALXT-" ADPT_FMT, ADPT_ARG(padapter)); |
| thread_enter(thread_name); |
| |
| DBG_871X("start "FUNC_ADPT_FMT"\n", FUNC_ADPT_ARG(padapter)); |
| -- |
| 2.7.4 |
| |
