| From 9753d75c82b0aa6500fdc7c4e2700d8c7816d802 Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Mon, 17 Feb 2020 17:40:50 +0300 |
| Subject: [PATCH] dmaengine: coh901318: Fix a double lock bug in |
| dma_tc_handle() |
| |
| commit 36d5d22090d13fd3a7a8c9663a711cbe6970aac8 upstream. |
| |
| The caller is already holding the lock so this will deadlock. |
| |
| Fixes: 0b58828c923e ("DMAENGINE: COH 901 318 remove irq counting") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Link: https://lore.kernel.org/r/20200217144050.3i4ymbytogod4ijn@kili.mountain |
| Signed-off-by: Vinod Koul <vkoul@kernel.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/dma/coh901318.c b/drivers/dma/coh901318.c |
| index 547786ac342b..8c390736b05d 100644 |
| --- a/drivers/dma/coh901318.c |
| +++ b/drivers/dma/coh901318.c |
| @@ -1949,8 +1949,6 @@ static void dma_tc_handle(struct coh901318_chan *cohc) |
| return; |
| } |
| |
| - spin_lock(&cohc->lock); |
| - |
| /* |
| * When we reach this point, at least one queue item |
| * should have been moved over from cohc->queue to |
| @@ -1971,8 +1969,6 @@ static void dma_tc_handle(struct coh901318_chan *cohc) |
| if (coh901318_queue_start(cohc) == NULL) |
| cohc->busy = 0; |
| |
| - spin_unlock(&cohc->lock); |
| - |
| /* |
| * This tasklet will remove items from cohc->active |
| * and thus terminates them. |
| -- |
| 2.7.4 |
| |
