| From 7c7e9dd932859970e12c8c08586449ee9bb80959 Mon Sep 17 00:00:00 2001 |
| From: Pan Bian <bianpan2016@163.com> |
| Date: Tue, 5 Nov 2019 17:25:27 +0800 |
| Subject: [PATCH] scsi: qla4xxx: fix double free bug |
| |
| commit 3fe3d2428b62822b7b030577cd612790bdd8c941 upstream. |
| |
| The variable init_fw_cb is released twice, resulting in a double free |
| bug. The call to the function dma_free_coherent() before goto is removed to |
| get rid of potential double free. |
| |
| Fixes: 2a49a78ed3c8 ("[SCSI] qla4xxx: added IPv6 support.") |
| Link: https://lore.kernel.org/r/1572945927-27796-1-git-send-email-bianpan2016@163.com |
| Signed-off-by: Pan Bian <bianpan2016@163.com> |
| Acked-by: Manish Rangankar <mrangankar@marvell.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/scsi/qla4xxx/ql4_mbx.c b/drivers/scsi/qla4xxx/ql4_mbx.c |
| index dac9a7013208..02636b4785c5 100644 |
| --- a/drivers/scsi/qla4xxx/ql4_mbx.c |
| +++ b/drivers/scsi/qla4xxx/ql4_mbx.c |
| @@ -640,9 +640,6 @@ int qla4xxx_initialize_fw_cb(struct scsi_qla_host * ha) |
| |
| if (qla4xxx_get_ifcb(ha, &mbox_cmd[0], &mbox_sts[0], init_fw_cb_dma) != |
| QLA_SUCCESS) { |
| - dma_free_coherent(&ha->pdev->dev, |
| - sizeof(struct addr_ctrl_blk), |
| - init_fw_cb, init_fw_cb_dma); |
| goto exit_init_fw_cb; |
| } |
| |
| -- |
| 2.7.4 |
| |
