| From 143cc83e0acd24f3c211d9ef12f8a71ac9230488 Mon Sep 17 00:00:00 2001 |
| From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> |
| Date: Thu, 30 Jan 2020 22:13:51 -0800 |
| Subject: [PATCH] lib/test_kasan.c: fix memory leak in |
| kmalloc_oob_krealloc_more() |
| |
| commit 3e21d9a501bf99aee2e5835d7f34d8c823f115b5 upstream. |
| |
| In case memory resources for _ptr2_ were allocated, release them before |
| return. |
| |
| Notice that in case _ptr1_ happens to be NULL, krealloc() behaves |
| exactly like kmalloc(). |
| |
| Addresses-Coverity-ID: 1490594 ("Resource leak") |
| Link: http://lkml.kernel.org/r/20200123160115.GA4202@embeddedor |
| Fixes: 3f15801cdc23 ("lib: add kasan test module") |
| Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> |
| Reviewed-by: Dmitry Vyukov <dvyukov@google.com> |
| Cc: <stable@vger.kernel.org> |
| Signed-off-by: Andrew Morton <akpm@linux-foundation.org> |
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/lib/test_kasan.c b/lib/test_kasan.c |
| index e3c593c38eff..248062b0bf64 100644 |
| --- a/lib/test_kasan.c |
| +++ b/lib/test_kasan.c |
| @@ -153,6 +153,7 @@ static noinline void __init kmalloc_oob_krealloc_more(void) |
| if (!ptr1 || !ptr2) { |
| pr_err("Allocation failed\n"); |
| kfree(ptr1); |
| + kfree(ptr2); |
| return; |
| } |
| |
| -- |
| 2.7.4 |
| |
