commit 137719019fc1f4e27d1e715eabb0915388ee64cf
author kernel test robot <lkp@intel.com> Sun Sep 27 15:00:29 2020 +0200
committer Paul E. McKenney <paulmck@kernel.org> Mon Sep 28 15:35:20 2020 -0700
tree 547ec06a8d71edbe38d8089e74199bfa2c8c1ebd
parent da91a72b9716aaa7b1b2ef358cbc95fe1d519a0e

kvfree_rcu(): Fix ifnullfree.cocci warnings

NULL check before kfree is not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Fixes: da91a72b9716 ("rcu/tree: Allocate a page when caller is preemptable")
Acked-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>

kernel/rcu/tree.c

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index cc998d7..4a85ea2 100644
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -3165,8 +3165,7 @@ static void kfree_rcu_work(struct work_struct *work)
 				bkvhead[i] = NULL;
 			krc_this_cpu_unlock(krcp, flags);
 
-			if (bkvhead[i])
-				kfree(bkvhead[i]);
+			kfree(bkvhead[i]);
 
 			cond_resched_tasks_rcu_qs();
 		}