tree b16af5d1fcabe792f0b565d9fca2686cad480efd
parent 9ea88a153001ffeb3d8810917e8eea62ca9b6f25
author Thomas Graf <tgraf@suug.ch> 1407367127 +0100
committer David S. Miller <davem@davemloft.net> 1407377864 -0700

netlink: hold nl_sock_hash_lock during diag dump

Although RCU protection would be possible during diag dump, doing
so allows for concurrent table mutations which can render the
in-table offset between individual Netlink messages invalid and
thus cause legitimate sockets to be skipped in the dump.

Since the diag dump is relatively low volume and consistency is
more important than performance, the table mutex is held during
dump.

Reported-by: Andrey Wagin <avagin@gmail.com>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
Fixes: e341694e3eb57fc ("netlink: Convert netlink_lookup() to use RCU protected hash table")
Signed-off-by: David S. Miller <davem@davemloft.net>