)]}'
{
  "commit": "0561794b6b642b84b879bf97061c4b4fa692839e",
  "tree": "7f5da2000cf00a777051b892cc53ed0f252f9b40",
  "parents": [
    "018903e1cec3421a6198589fabd30682eb277904"
  ],
  "author": {
    "name": "Andrzej Hajda",
    "email": "andrzej.hajda@intel.com",
    "time": "Wed Nov 15 11:54:03 2023 +0100"
  },
  "committer": {
    "name": "Jani Nikula",
    "email": "jani.nikula@intel.com",
    "time": "Mon Nov 20 11:06:53 2023 +0200"
  },
  "message": "drm/i915: do not clean GT table on error path\n\nThe only task of intel_gt_release_all is to zero gt table. Calling\nit on error path prevents intel_gt_driver_late_release_all (called from\ni915_driver_late_release) to cleanup GTs, causing leakage.\nAfter i915_driver_late_release GT array is not used anymore so\nit does not need cleaning at all.\n\nSample leak report:\n\nBUG i915_request (...): Objects remaining in i915_request on __kmem_cache_shutdown()\n...\nObject 0xffff888113420040 @offset\u003d64\nAllocated in __i915_request_create+0x75/0x610 [i915] age\u003d18339 cpu\u003d1 pid\u003d1454\n kmem_cache_alloc+0x25b/0x270\n __i915_request_create+0x75/0x610 [i915]\n i915_request_create+0x109/0x290 [i915]\n __engines_record_defaults+0xca/0x440 [i915]\n intel_gt_init+0x275/0x430 [i915]\n i915_gem_init+0x135/0x2c0 [i915]\n i915_driver_probe+0x8d1/0xdc0 [i915]\n\nv2: removed whole intel_gt_release_all\n\nCloses: https://gitlab.freedesktop.org/drm/intel/-/issues/8489\nFixes: bec68cc9ea42 (\"drm/i915: Prepare for multiple GTs\")\nSigned-off-by: Andrzej Hajda \u003candrzej.hajda@intel.com\u003e\nReviewed-by: Tvrtko Ursulin \u003ctvrtko.ursulin@intel.com\u003e\nReviewed-by: Nirmoy Das \u003cnirmoy.das@intel.com\u003e\nReviewed-by: Andi Shyti \u003candi.shyti@linux.intel.com\u003e\nLink: https://patchwork.freedesktop.org/patch/msgid/20231115-dont_clean_gt_on_error_path-v2-1-54250125470a@intel.com\n(cherry picked from commit e899505533852bf1da133f2f4c9a9655ff77f7e5)\nSigned-off-by: Jani Nikula \u003cjani.nikula@intel.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ed32bf5b15464e63efceedc7752e851dea8ad212",
      "old_mode": 33188,
      "old_path": "drivers/gpu/drm/i915/gt/intel_gt.c",
      "new_id": "ba1186fc524f84c9d5d0c8a1481b6d0bf301607c",
      "new_mode": 33188,
      "new_path": "drivers/gpu/drm/i915/gt/intel_gt.c"
    },
    {
      "type": "modify",
      "old_id": "8a0e2c745e1f9e40051cf0313134f5aa58a78f07",
      "old_mode": 33188,
      "old_path": "drivers/gpu/drm/i915/i915_driver.c",
      "new_id": "802de2c6decb7b0e78f206ac4edb20c7e6c58941",
      "new_mode": 33188,
      "new_path": "drivers/gpu/drm/i915/i915_driver.c"
    }
  ]
}
