)]}'
{
  "commit": "864fb5d3716303a045c3ffb397f651bfd37bfb36",
  "tree": "352e8b51937941b22a0b70ce0d7c1cf00f9cf015",
  "parents": [
    "90044481e7cca6cb3125b3906544954a25f1309f"
  ],
  "author": {
    "name": "Namjae Jeon",
    "email": "linkinjeon@kernel.org",
    "time": "Mon Nov 20 09:23:09 2023 +0900"
  },
  "committer": {
    "name": "Steve French",
    "email": "stfrench@microsoft.com",
    "time": "Thu Nov 23 20:50:45 2023 -0600"
  },
  "message": "ksmbd: fix possible deadlock in smb2_open\n\n[ 8743.393379] \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n[ 8743.393385] WARNING: possible circular locking dependency detected\n[ 8743.393391] 6.4.0-rc1+ #11 Tainted: G           OE\n[ 8743.393397] ------------------------------------------------------\n[ 8743.393402] kworker/0:2/12921 is trying to acquire lock:\n[ 8743.393408] ffff888127a14460 (sb_writers#8){.+.+}-{0:0}, at: ksmbd_vfs_setxattr+0x3d/0xd0 [ksmbd]\n[ 8743.393510]\n               but task is already holding lock:\n[ 8743.393515] ffff8880360d97f0 (\u0026type-\u003ei_mutex_dir_key#6/1){+.+.}-{3:3}, at: ksmbd_vfs_kern_path_locked+0x181/0x670 [ksmbd]\n[ 8743.393618]\n               which lock already depends on the new lock.\n\n[ 8743.393623]\n               the existing dependency chain (in reverse order) is:\n[ 8743.393628]\n               -\u003e #1 (\u0026type-\u003ei_mutex_dir_key#6/1){+.+.}-{3:3}:\n[ 8743.393648]        down_write_nested+0x9a/0x1b0\n[ 8743.393660]        filename_create+0x128/0x270\n[ 8743.393670]        do_mkdirat+0xab/0x1f0\n[ 8743.393680]        __x64_sys_mkdir+0x47/0x60\n[ 8743.393690]        do_syscall_64+0x5d/0x90\n[ 8743.393701]        entry_SYSCALL_64_after_hwframe+0x72/0xdc\n[ 8743.393711]\n               -\u003e #0 (sb_writers#8){.+.+}-{0:0}:\n[ 8743.393728]        __lock_acquire+0x2201/0x3b80\n[ 8743.393737]        lock_acquire+0x18f/0x440\n[ 8743.393746]        mnt_want_write+0x5f/0x240\n[ 8743.393755]        ksmbd_vfs_setxattr+0x3d/0xd0 [ksmbd]\n[ 8743.393839]        ksmbd_vfs_set_dos_attrib_xattr+0xcc/0x110 [ksmbd]\n[ 8743.393924]        compat_ksmbd_vfs_set_dos_attrib_xattr+0x39/0x50 [ksmbd]\n[ 8743.394010]        smb2_open+0x3432/0x3cc0 [ksmbd]\n[ 8743.394099]        handle_ksmbd_work+0x2c9/0x7b0 [ksmbd]\n[ 8743.394187]        process_one_work+0x65a/0xb30\n[ 8743.394198]        worker_thread+0x2cf/0x700\n[ 8743.394209]        kthread+0x1ad/0x1f0\n[ 8743.394218]        ret_from_fork+0x29/0x50\n\nThis patch add mnt_want_write() above parent inode lock and remove\nnested mnt_want_write calls in smb2_open().\n\nFixes: 40b268d384a2 (\"ksmbd: add mnt_want_write to ksmbd vfs functions\")\nCc: stable@vger.kernel.org\nReported-by: Marios Makassikis \u003cmmakassikis@freebox.fr\u003e\nSigned-off-by: Namjae Jeon \u003clinkinjeon@kernel.org\u003e\nSigned-off-by: Steve French \u003cstfrench@microsoft.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "658209839729ce665d6514fc1b59efd8d3d3294a",
      "old_mode": 33188,
      "old_path": "fs/smb/server/smb2pdu.c",
      "new_id": "c996264db2c65c8c1cdfff2d14a164df5ed7862b",
      "new_mode": 33188,
      "new_path": "fs/smb/server/smb2pdu.c"
    },
    {
      "type": "modify",
      "old_id": "51b8bfab74813fb3f79bc85e2155eeebd84f2d79",
      "old_mode": 33188,
      "old_path": "fs/smb/server/smbacl.c",
      "new_id": "1164365533f08957d80a082f17a10499ddec37ee",
      "new_mode": 33188,
      "new_path": "fs/smb/server/smbacl.c"
    },
    {
      "type": "modify",
      "old_id": "49a8c292bd2e81c33a6e24434a0a91d4dfb5a2fc",
      "old_mode": 33188,
      "old_path": "fs/smb/server/smbacl.h",
      "new_id": "2b52861707d8c11233a8c370f50cdf79493b7e46",
      "new_mode": 33188,
      "new_path": "fs/smb/server/smbacl.h"
    },
    {
      "type": "modify",
      "old_id": "c53dea5598fc63718e5df7f42e2079d5ac00497a",
      "old_mode": 33188,
      "old_path": "fs/smb/server/vfs.c",
      "new_id": "533257b46fc17105893d2fec01fa5cf1876162b3",
      "new_mode": 33188,
      "new_path": "fs/smb/server/vfs.c"
    },
    {
      "type": "modify",
      "old_id": "00968081856e38288953aeb927eb9700d1a2a348",
      "old_mode": 33188,
      "old_path": "fs/smb/server/vfs.h",
      "new_id": "cfe1c8092f2302f2cd0ea7cf5b42f1357160981f",
      "new_mode": 33188,
      "new_path": "fs/smb/server/vfs.h"
    }
  ]
}
