tag d62994340d5297bb9ef11b1fcb0e07ca2265ea15
tagger Richard Weinberger <richard@nod.at> Fri Jun 03 11:09:13 2022 +0200
object 8c03a1c21d72210f81cb369cc528e3fde4b45411

This pull request contains fixes for JFFS2, UBI and UBIFS

JFFS2:
        - Fixes for a memory leak

UBI:
        - Fixes for fastmap (UAF, high CPU usage)

UBIFS:
        - Minor cleanups

commit 8c03a1c21d72210f81cb369cc528e3fde4b45411
author Zhihao Cheng <chengzhihao1@huawei.com> Tue May 10 20:31:26 2022 +0800
committer Richard Weinberger <richard@nod.at> Fri May 27 16:49:41 2022 +0200
tree 3522098526b91e0b24e51fa36ed869ba64939b4f
parent 14072ee33d5a2a07d735b667205f99d0a95de9f2

ubi: ubi_create_volume: Fix use-after-free when volume creation failed

There is an use-after-free problem for 'eba_tbl' in ubi_create_volume()'s
error handling path:

  ubi_eba_replace_table(vol, eba_tbl)
    vol->eba_tbl = tbl
out_mapping:
  ubi_eba_destroy_table(eba_tbl)   // Free 'eba_tbl'
out_unlock:
  put_device(&vol->dev)
    vol_release
      kfree(tbl->entries)	  // UAF

Fix it by removing redundant 'eba_tbl' releasing.
Fetch a reproducer in [Link].

Fixes: 493cfaeaa0c9b ("mtd: utilize new cdev_device_add helper function")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=215965
Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>