)]}' { "log": [ { "commit": "0cfb2952319d237f1d079097810546f24e3883bf", "tree": "8b0efe3801e4646c48dd2b932a3aad562b1c6a1c", "parents": [ "a4e8b806d02fdb3b74b6d60546093f88f010f3b9" ], "author": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Dec 20 16:47:12 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Fri Dec 20 16:47:12 2019 -0500" }, "message": "xfsprogs: Release v5.4.0\n\nUpdate all the necessary files for a 5.4.0 release.\n\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n" }, { "commit": "a4e8b806d02fdb3b74b6d60546093f88f010f3b9", "tree": "264363da4a8804c6325c1531738ba8f92818d1e4", "parents": [ "2383d7c5cf20efcff75cb29ca3e02cfbe1bf2209" ], "author": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Tue Dec 17 16:59:46 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Tue Dec 17 16:59:46 2019 -0500" }, "message": "xfsprogs: Release v5.4.0-rc1\n\nUpdate all the necessary files for a 5.4.0-rc1 prerelease.\n\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "2383d7c5cf20efcff75cb29ca3e02cfbe1bf2209", "tree": "293c8157cd3beca96f36df7879f08f3e2075dbb1", "parents": [ "7e8a6edb4d1ba0079152eb477abbbc1dfb1ebb7e" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Tue Dec 17 16:52:39 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Tue Dec 17 16:52:39 2019 -0500" }, "message": "mkfs: tidy up discard notifications\n\nOnly notify user of discard operations if the first one succeeds,\nand be sure to print a trailing newline if we stop early.\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n" }, { "commit": "7e8a6edb4d1ba0079152eb477abbbc1dfb1ebb7e", "tree": "131b7e4d3c96fea89bd2a6663ff9dd8c86618668", "parents": [ "3f153e051abccce0c120ade5c08a675a50cecee9" ], "author": { "name": "Pavel Reichl", "email": "preichl@redhat.com", "time": "Fri Dec 13 16:21:26 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Fri Dec 13 16:21:26 2019 -0500" }, "message": "mkfs: Break block discard into chunks of 2 GB\n\nSome users are not happy about the BLKDISCARD taking too long and at the\nsame time not being informed about that - so they think that the command\nactually hung.\n\nThis commit changes code so that progress reporting is possible and also\ntyping the ^C will cancel the ongoing BLKDISCARD.\n\nSigned-off-by: Pavel Reichl \u003cpreichl@redhat.com\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "3f153e051abccce0c120ade5c08a675a50cecee9", "tree": "db366664677a0f7f4ce4a12b310c412eb40e909b", "parents": [ "8db10a9a14a8f9308d7b89b776b6a4029405d612" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Dec 13 16:21:19 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Fri Dec 13 16:21:19 2019 -0500" }, "message": "xfs_admin: enable online label getting and setting\n\nConnect xfs_admin -L to the xfs_io label command so that we can get and\nset the label for a live filesystem.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Carlos Maiolino \u003ccmaiolino@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "8db10a9a14a8f9308d7b89b776b6a4029405d612", "tree": "48597c1f37593248e16fcbafd66ea5b60e2e92f1", "parents": [ "2ab6ea6a4cf7f7be6def5444229739effc6bad5b" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Dec 13 16:21:18 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Fri Dec 13 16:21:18 2019 -0500" }, "message": "xfs_admin: support external log devices\n\nAdd to xfs_admin the ability to pass external log devices to xfs_db.\nThis is necessary to make changes on such filesystems.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Carlos Maiolino \u003ccmaiolino@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "2ab6ea6a4cf7f7be6def5444229739effc6bad5b", "tree": "5d91c07f484c4a1330a94d7e61e8c9777feccd75", "parents": [ "998aed52bede0194531092247cbf7ebd015ad054" ], "author": { "name": "John Pittman", "email": "jpittman@redhat.com", "time": "Fri Dec 13 16:21:17 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Fri Dec 13 16:21:17 2019 -0500" }, "message": "xfsprogs: add missing line feeds in libxfs/rdwr.c\n\nIn libxfs/rdwr.c, there are several fprintf() calls that are\nmissing trailing line feeds. This translates to the following\nCLI prompt being on the same line as the message. Add missing\nline feeds, alleviating the issue.\n\nFixes: 0a7942b38215 (\"libxfs: don\u0027t discard dirty buffers\")\nSigned-off-by: John Pittman \u003cjpittman@redhat.com\u003e\nReviewed-by: Carlos Maiolino \u003ccmaiolino@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "998aed52bede0194531092247cbf7ebd015ad054", "tree": "df9148572745d61392bf49bf3d8c13099e06d488", "parents": [ "6f1df6a36f81941fdaac257b7717484619e2124a" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Fri Dec 13 16:21:16 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Fri Dec 13 16:21:16 2019 -0500" }, "message": "xfsprogs: remove stray libxfs whitespace\n\nNot quite sure how these crept in but now\u0027s as good a time as any\nto remove stray newline deltas vs. the kernel code.\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "6f1df6a36f81941fdaac257b7717484619e2124a", "tree": "a8ac18259161f9c850d9fc406b323353e299a814", "parents": [ "0f498e72204712d7608210942db023e98aab1180" ], "author": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Dec 13 16:21:06 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Fri Dec 13 16:21:06 2019 -0500" }, "message": "xfsprogs: Release v5.4.0-rc0\n\nUpdate all the necessary files for a 5.4.0-rc0 prerelease.\n \nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n\n" }, { "commit": "0f498e72204712d7608210942db023e98aab1180", "tree": "4f2ed10b0a7465e63e99381d386b58607d4d8d04", "parents": [ "feee8e52e6e3e55042088f54606347dceb16aac5" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: change the seconds fields in xfs_bulkstat to signed\n\nSource kernel commit: 5e0cd1ef64744e41e029dfca7d0ae285c486f386\n\n64-bit time is a signed quantity in the kernel, so the bulkstat\nstructure should reflect that. Note that the structure size stays\nthe same and that we have not yet published userspace headers for this\nnew ioctl so there are no users to break.\n\nFixes: 7035f9724f84 (\"xfs: introduce new v5 bulkstat structure\")\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Carlos Maiolino \u003ccmaiolino@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "feee8e52e6e3e55042088f54606347dceb16aac5", "tree": "06911f7b7d95d78dd372132db71d87cde30745eb", "parents": [ "a35db947e05273dd643beeb4088cc67c55b6a8f6" ], "author": { "name": "Brian Foster", "email": "bfoster@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: move local to extent inode logging into bmap helper\n\nSource kernel commit: aeea4b75f045294e1c026acc380466daa43afc65\n\nThe callers of xfs_bmap_local_to_extents_empty() log the inode\nexternal to the function, yet this function is where the on-disk\nformat value is updated. Push the inode logging down into the\nfunction itself to help prevent future mistakes.\n\nNote that internal bmap callers track the inode logging flags\nindependently and thus may log the inode core twice due to this\nchange. This is harmless, so leave this code around for consistency\nwith the other attr fork conversion functions.\n\nSigned-off-by: Brian Foster \u003cbfoster@redhat.com\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "a35db947e05273dd643beeb4088cc67c55b6a8f6", "tree": "6533eaf789d361f776bb33f547588ee045ac4743", "parents": [ "2e3614c7b0912b2f76bbf82b7205ea21bc5c28c4" ], "author": { "name": "Brian Foster", "email": "bfoster@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: remove broken error handling on failed attr sf to leaf change\n\nSource kernel commit: 603efebd6768356fb7cea02e4a822587c2dc5d7c\n\nxfs_attr_shortform_to_leaf() attempts to put the shortform fork back\ntogether after a failed attempt to convert from shortform to leaf\nformat. While this code reallocates and copies back the shortform\nattr fork data, it never resets the inode format field back to local\nformat. Further, now that the inode is properly logged after the\ninitial switch from local format, any error that triggers the\nrecovery code will eventually abort the transaction and shutdown the\nfs. Therefore, remove the broken and unnecessary error handling\ncode.\n\nSigned-off-by: Brian Foster \u003cbfoster@redhat.com\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "2e3614c7b0912b2f76bbf82b7205ea21bc5c28c4", "tree": "b447b0160040a958e103a8df21b58d315eb011af", "parents": [ "2671b64db32001f23f2b5b05f3c403753e416572" ], "author": { "name": "Brian Foster", "email": "bfoster@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: log the inode on directory sf to block format change\n\nSource kernel commit: 0b10d8a89f55c416f6a1f6a616669543fa8bdb69\n\nWhen a directory changes from shortform (sf) to block format, the sf\nformat is copied to a temporary buffer, the inode format is modified\nand the updated format filled with the dentries from the temporary\nbuffer. If the inode format is modified and attempt to grow the\ninode fails (due to I/O error, for example), it is possible to\nreturn an error while leaving the directory in an inconsistent state\nand with an otherwise clean transaction. This results in corruption\nof the associated directory and leads to xfs_dabuf_map() errors as\nsubsequent lookups cannot accurately determine the format of the\ndirectory. This problem is reproduced occasionally by generic/475.\n\nThe fundamental problem is that xfs_dir2_sf_to_block() changes the\non-disk inode format without logging the inode. The inode is\neventually logged by the bmapi layer in the common case, but error\nchecking introduces the possibility of failing the high level\nrequest before this happens.\n\nUpdate both of the dir2 and attr callers of\nxfs_bmap_local_to_extents_empty() to log the inode core as\nconsistent with the bmap local to extent format change codepath.\nThis ensures that any subsequent errors after the format has changed\ncause the transaction to abort.\n\nSigned-off-by: Brian Foster \u003cbfoster@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "2671b64db32001f23f2b5b05f3c403753e416572", "tree": "267a9ddd3c0a3e27a7f5356e4648e11fa03b304a", "parents": [ "55b503df9f2b35984ee83288f9bf0808c8eff0d2" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: remove unused flags arg from xfs_get_aghdr_buf()\n\nSource kernel commit: 6374ca03975ab0a2b1a5ced222e0ef2ea6e22f9e\n\nThe flags arg is always passed as zero, so remove it.\n\n(xfs_buf_get_uncached takes flags to support XBF_NO_IOACCT for\nthe sb, but that should never be relevant for xfs_get_aghdr_buf)\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nReviewed-by: Carlos Maiolino \u003ccmaiolino@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "55b503df9f2b35984ee83288f9bf0808c8eff0d2", "tree": "507e25cf32d5f18cdd140658fa4c6de8b6b286ee", "parents": [ "c3fcbe145a554a1fdc62371557d8c7a2e7214204" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: log proper length of superblock\n\nSource kernel commit: 6f4ff81a4602dcfba436c6e2307d61ce9e9f652c\n\nxfs_trans_log_buf takes first byte, last byte as args. In this\ncase, it should be from 0 to sizeof() - 1.\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nReviewed-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "c3fcbe145a554a1fdc62371557d8c7a2e7214204", "tree": "55d54354d42f60d1a537bb4357af783b3ca98a1b", "parents": [ "e102336b41368b72477dc225fe6c4dd0546e2f3c" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: revert 1baa2800e62d (\"xfs: remove the unused XFS_ALLOC_USERDATA flag\")\n\nSource kernel commit: ce840429260a98bcfe4aaf487bb07fa346d86c41\n\nRevert this commit, as it caused periodic regressions in xfs/173 w/\n1k blocks.\n\n[1] https://lore.kernel.org/lkml/20190919014602.GN15734@shao2-debian/\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Brian Foster \u003cbfoster@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "e102336b41368b72477dc225fe6c4dd0546e2f3c", "tree": "295d03ec4258c6cda2cab90043c095392393ba5e", "parents": [ "feb5c73766296003f4607eec3a448b7fef48fa80" ], "author": { "name": "Brian Foster", "email": "bfoster@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: convert inode to extent format after extent merge due to shift\n\nSource kernel commit: e20e174ca1bd98241b42d5ccfa228d8c6522e4e7\n\nThe collapse range operation can merge extents if two newly adjacent\nextents are physically contiguous. If the extent count is reduced on\na btree format inode, a change to extent format might be necessary.\nThis format change currently occurs as a side effect of the file\nsize update after extents have been shifted for the collapse. This\ncodepath ultimately calls xfs_bunmapi(), which happens to check for\nand execute the format conversion even if there were no blocks\nremoved from the mapping.\n\nWhile this ultimately puts the inode into the correct state, the\nfact the format conversion occurs in a separate transaction from the\nchange that called for it is a problem. If an extent shift\ntransaction commits and the filesystem happens to crash before the\nformat conversion, the inode fork is left in a corrupted state after\nlog recovery. The inode fork verifier fails and xfs_repair\nultimately nukes the inode. This problem was originally reproduced\nby generic/388.\n\nSimilar to how the insert range extent split code handles extent to\nbtree conversion, update the collapse range extent merge code to\nhandle btree to extent format conversion in the same transaction\nthat merges the extents. This ensures that the inode fork format\nremains consistent if the filesystem happens to crash in the middle\nof a collapse range operation that changes the inode fork format.\n\nSigned-off-by: Brian Foster \u003cbfoster@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "feb5c73766296003f4607eec3a448b7fef48fa80", "tree": "5ab41529b932030c5750f1c31f2ce67024d78ba8", "parents": [ "14790ed01c2d615cc3c534b597cd1123bc95ad92" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: define a flags field for the AG geometry ioctl structure\n\nSource kernel commit: 76f1793359db07205b9aefba66c7acbac988aaac\n\nDefine a flags field for the AG geometry ioctl structure.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "14790ed01c2d615cc3c534b597cd1123bc95ad92", "tree": "6348fbf97f18ad8f2872211168ad861a24eb4421", "parents": [ "ed110c33ac4f7b2a4d1ec12fdef4132562e9e060" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: add a xfs_valid_startblock helper\n\nSource kernel commit: eb77b23b565e7e1d2cc3a7d9e4cc186fb54e81a8\n\nAdd a helper that validates the startblock is valid. This checks for a\nnon-zero block on the main device, but skips that check for blocks on\nthe realtime device.\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "ed110c33ac4f7b2a4d1ec12fdef4132562e9e060", "tree": "921dee961c801dee4d7157ba406a405a0780f57c", "parents": [ "b4b9ad30b50a6760ca7eba134120f169104b3463" ], "author": { "name": "Christoph Hellwig", "email": "hch@lst.de", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: remove the unused XFS_ALLOC_USERDATA flag\n\nSource kernel commit: 1baa2800e62d7d58c04cb871a6e4189fc3e1ccf1\n\nSigned-off-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "b4b9ad30b50a6760ca7eba134120f169104b3463", "tree": "b76ca476c38ff630ddd389cd51eb1e88519068b5", "parents": [ "4343d3037b376ed7feaec1510e48cd3e54b49cec" ], "author": { "name": "Dave Chinner", "email": "dchinner@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: allocate xattr buffer on demand\n\nSource kernel commit: ddbca70cc45c0ac97ff6d9529e45f10b8ae73ad4\n\nWhen doing file lookups and checking for permissions, we end up in\nxfs_get_acl() to see if there are any ACLs on the inode. This\nrequires and xattr lookup, and to do that we have to supply a buffer\nlarge enough to hold an maximum sized xattr.\n\nOn workloads were we are accessing a wide range of cache cold files\nunder memory pressure (e.g. NFS fileservers) we end up spending a\nlot of time allocating the buffer. The buffer is 64k in length, so\nis a contiguous multi-page allocation, and if that then fails we\nfall back to vmalloc(). Hence the allocation here is /expensive/\nwhen we are looking up hundreds of thousands of files a second.\n\nInitial numbers from a bpf trace show average time in xfs_get_acl()\nis ~32us, with ~19us of that in the memory allocation. Note these\nare average times, so there are going to be affected by the worst\ncase allocations more than the common fast case...\n\nTo avoid this, we could just do a \"null\" lookup to see if the ACL\nxattr exists and then only do the allocation if it exists. This,\nhowever, optimises the path for the \"no ACL present\" case at the\nexpense of the \"acl present\" case. i.e. we can halve the time in\nxfs_get_acl() for the no acl case (i.e down to ~10-15us), but that\nthen increases the ACL case by 30% (i.e. up to 40-45us).\n\nTo solve this and speed up both cases, drive the xattr buffer\nallocation into the attribute code once we know what the actual\nxattr length is. For the no-xattr case, we avoid the allocation\ncompletely, speeding up that case. For the common ACL case, we\u0027ll\nend up with a fast heap allocation (because it\u0027ll be smaller than a\npage), and only for the rarer \"we have a remote xattr\" will we have\na multi-page allocation occur. Hence the common ACL case will be\nmuch faster, too.\n\nSigned-off-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "4343d3037b376ed7feaec1510e48cd3e54b49cec", "tree": "e3f54ca6dd29d3bfd84662383d84271f4dcb3f80", "parents": [ "17e7277101b149cf0e5af4ea811c315f7abae855" ], "author": { "name": "Dave Chinner", "email": "dchinner@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: consolidate attribute value copying\n\nSource kernel commit: 9df243a1a9e607e7cf5d20ee46edd5ec84b7e400\n\nThe same code is used to copy do the attribute copying in three\ndifferent places. Consolidate them into a single function in\npreparation from on-demand buffer allocation.\n\nSigned-off-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "17e7277101b149cf0e5af4ea811c315f7abae855", "tree": "a99a95ea384f620286e0da341913d250d8df4f6d", "parents": [ "ab0d25d8bf4613f56732ae6bc7fd2c654de093ce" ], "author": { "name": "Dave Chinner", "email": "dchinner@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: move remote attr retrieval into xfs_attr3_leaf_getvalue\n\nSource kernel commit: e3cc4554ce1b2cc43262c93ebe6d8cde780d29ee\n\nBecause we repeat exactly the same code to get the remote attribute\nvalue after both calls to xfs_attr3_leaf_getvalue() if it\u0027s a remote\nattr. Just do it in xfs_attr3_leaf_getvalue() so the callers don\u0027t\nhave to care about it.\n\nSigned-off-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "ab0d25d8bf4613f56732ae6bc7fd2c654de093ce", "tree": "f11440ebc7261e050ddd154e9adf8b72bb6ee5e2", "parents": [ "42a383ab754b23f0f639431da0103427f9d84631" ], "author": { "name": "Dave Chinner", "email": "dchinner@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: remove unnecessary indenting from xfs_attr3_leaf_getvalue\n\nSource kernel commit: a0e959d3c9d52a83e01a97ef352a1465550f9329\n\nSigned-off-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "42a383ab754b23f0f639431da0103427f9d84631", "tree": "322ab159265602168acab27228511cc16318bae2", "parents": [ "b5784c097ed9dcb0eeec9332cafeb350f8662fa8" ], "author": { "name": "Dave Chinner", "email": "dchinner@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: make attr lookup returns consistent\n\nSource kernel commit: 728bcaa3e0f9820e923dabe5e4c34e87100bb995\n\nShortform, leaf and remote value attr value retrieval return\ndifferent values for success. This makes it more complex to handle\nactual errors xfs_attr_get() as some errors mean success and some\nmean failure. Make the return values consistent for success and\nfailure consistent for all attribute formats.\n\nSigned-off-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "b5784c097ed9dcb0eeec9332cafeb350f8662fa8", "tree": "b2a01a335ee2dcb4e6969dfb95f2c9f384c90858", "parents": [ "4ebdc2c86c0de33888f0bac59fcca35a47495e42" ], "author": { "name": "Dave Chinner", "email": "dchinner@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: reverse search directory freespace indexes\n\nSource kernel commit: 756c6f0f7efe8759ff6dda35d220e2e753e2b0e3\n\nWhen a directory is growing rapidly, new blocks tend to get added at\nthe end of the directory. These end up at the end of the freespace\nindex, and when the directory gets large finding these new\nfreespaces gets expensive. The code does a linear search across the\nfrespace index from the first block in the directory to the last,\nhence meaning the newly added space is the last index searched.\n\nInstead, do a reverse order index search, starting from the last\nblock and index in the freespace index. This makes most lookups for\nfree space on rapidly growing directories O(1) instead of O(N), but\nshould not have any impact on random insert workloads because the\naverage search length is the same regardless of which end of the\narray we start at.\n\nThe result is a major improvement in large directory grow rates:\n\ncreate time(sec) / rate (files/s)\nFile count vanilla Prev commit Patched\n10k 0.41 / 24.3k 0.42 / 23.8k 0.41 / 24.3k\n20k 0.74 / 27.0k 0.76 / 26.3k 0.75 / 26.7k\n100k 3.81 / 26.4k 3.47 / 28.8k 3.27 / 30.6k\n200k 8.58 / 23.3k 7.19 / 27.8k 6.71 / 29.8k\n1M 85.69 / 11.7k 48.53 / 20.6k 37.67 / 26.5k\n2M 280.31 / 7.1k 130.14 / 15.3k 79.55 / 25.2k\n10M 3913.26 / 2.5k 552.89 / 18.1k\n\nSigned-off-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "4ebdc2c86c0de33888f0bac59fcca35a47495e42", "tree": "0b3844be284bb164d7f80bffbe6f640ab0cafdf7", "parents": [ "64b80d8656ec0a64c5c6b3a0b88a9ad0276e0844" ], "author": { "name": "Dave Chinner", "email": "dchinner@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: speed up directory bestfree block scanning\n\nSource kernel commit: 610125ab1e4b1b48dcffe74d9d82b0606bf1b923\n\nWhen running a \"create millions inodes in a directory\" test\nrecently, I noticed we were spending a huge amount of time\nconverting freespace block headers from disk format to in-memory\nformat:\n\n31.47% [kernel] [k] xfs_dir2_node_addname\n17.86% [kernel] [k] xfs_dir3_free_hdr_from_disk\n3.55% [kernel] [k] xfs_dir3_free_bests_p\n\nWe shouldn\u0027t be hitting the best free block scanning code so hard\nwhen doing sequential directory creates, and it turns out there\u0027s\na highly suboptimal loop searching the the best free array in\nthe freespace block - it decodes the block header before checking\neach entry inside a loop, instead of decoding the header once before\nrunning the entry search loop.\n\nThis makes a massive difference to create rates. Profile now looks\nlike this:\n\n13.15% [kernel] [k] xfs_dir2_node_addname\n3.52% [kernel] [k] xfs_dir3_leaf_check_int\n3.11% [kernel] [k] xfs_log_commit_cil\n\nAnd the wall time/average file create rate differences are\njust as stark:\n\ncreate time(sec) / rate (files/s)\nFile count vanilla patched\n10k 0.41 / 24.3k 0.42 / 23.8k\n20k 0.74 / 27.0k 0.76 / 26.3k\n100k 3.81 / 26.4k 3.47 / 28.8k\n200k 8.58 / 23.3k 7.19 / 27.8k\n1M 85.69 / 11.7k 48.53 / 20.6k\n2M 280.31 / 7.1k 130.14 / 15.3k\n\nThe larger the directory, the bigger the performance improvement.\n\nSigned-off-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "64b80d8656ec0a64c5c6b3a0b88a9ad0276e0844", "tree": "4c916f8d02687d1c464a7aee6815515f62092c67", "parents": [ "34af510f542f1034ea1b08d9a2320bb2201daee5" ], "author": { "name": "Dave Chinner", "email": "dchinner@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: factor free block index lookup from xfs_dir2_node_addname_int()\n\nSource kernel commit: 0e822255f95db400e56e19773e04755d79b50bda\n\nSimplify the logic in xfs_dir2_node_addname_int() by factoring out\nthe free block index lookup code that finds a block with enough free\nspace for the entry to be added. The code that is moved gets a major\ncleanup at the same time, but there is no algorithm change here.\n\nSigned-off-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "34af510f542f1034ea1b08d9a2320bb2201daee5", "tree": "98792beb1e9261c1e8295545fafa93e0a36569fe", "parents": [ "e3d4203eeb8bc310047cf38be0d7ef2ee3a63947" ], "author": { "name": "Dave Chinner", "email": "dchinner@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: factor data block addition from xfs_dir2_node_addname_int()\n\nSource kernel commit: a07258a695281109422011182db069a0e6f8855e\n\nFactor out the code that adds a data block to a directory from\nxfs_dir2_node_addname_int(). This makes the code flow cleaner and\nmore obvious and provides clear isolation of upcoming optimsations.\n\nSigned-off-By: Dave Chinner \u003cdchinner@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "e3d4203eeb8bc310047cf38be0d7ef2ee3a63947", "tree": "4e506574dd993cea21ed1036cfe3fe3b328a5c1b", "parents": [ "7dd6dee1a1fc3f2443695a6c30944ec946a3b75e" ], "author": { "name": "Dave Chinner", "email": "dchinner@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: move xfs_dir2_addname()\n\nSource kernel commit: aee7754bbeb1000992ed7e6945418a145d181074\n\nThis gets rid of the need for a forward declaration of the static\nfunction xfs_dir2_addname_int() and readies the code for factoring\nof xfs_dir2_addname_int().\n\nSigned-off-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "7dd6dee1a1fc3f2443695a6c30944ec946a3b75e", "tree": "e81dd1605365a2df98e92d3a8426cfe0de7383d2", "parents": [ "a0f17dde9aeb56e0f59b3b05d019ccf8bac98986" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: remove all *_ITER_CONTINUE values\n\nSource kernel commit: 39ee2239a5a212cbba9d96050bd11cfd0f26634d\n\nIterator functions already use 0 to signal \"continue iterating\", so get\nrid of the #defines and just do it directly.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "a0f17dde9aeb56e0f59b3b05d019ccf8bac98986", "tree": "6be5514ac142ff3f006ac89c90f384558863a43a", "parents": [ "d4eb45adbe42a4a8a5348d70941d1617527f96cb" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: remove all *_ITER_ABORT values\n\nSource kernel commit: e7ee96dfb8c2687a29d2c5c3b06c967fa54b839c\n\nUse -ECANCELED to signal \"stop iterating\" instead of these magical\n*_ITER_ABORT values, since it\u0027s duplicative.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "d4eb45adbe42a4a8a5348d70941d1617527f96cb", "tree": "3667a44137c80f6f4898174feb5a2732371d6db3", "parents": [ "60a802ccc8fcc4b7480ab7ce8c4ce7b4a0caa205" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: reinitialize rm_flags when unpacking an offset into an rmap irec\n\nSource kernel commit: ffb5696f7555e44c04b7c1212fcd83ddedc43498\n\nIn xfs_rmap_irec_offset_unpack, we should always clear the contents of\nrm_flags before we begin unpacking the encoded (ondisk) offset into the\nincore rm_offset and incore rm_flags fields. Remove the open-coded\nfield zeroing as this encourages api misuse.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "60a802ccc8fcc4b7480ab7ce8c4ce7b4a0caa205", "tree": "0a197381615f5dc7341d2570beec6dee90f50563", "parents": [ "5965a48272d3eedf68cc95ebc77f4e500837ee49" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: remove unnecessary int returns from deferred bmap functions\n\nSource kernel commit: 3e08f42ae7828bac2e7445a950f5de2b08203352\n\nRemove the return value from the functions that schedule deferred bmap\noperations since they never fail and do not return status.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "5965a48272d3eedf68cc95ebc77f4e500837ee49", "tree": "9608d9ff9ea9858794ab08bb11de760d690db218", "parents": [ "46d29bb9033cc369b30ae902712f54d29e2a2dff" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: remove unnecessary int returns from deferred refcount functions\n\nSource kernel commit: 74b4c5d4a9c073162a37d1c20c95cb33152ca474\n\nRemove the return value from the functions that schedule deferred\nrefcount operations since they never fail and do not return status.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "46d29bb9033cc369b30ae902712f54d29e2a2dff", "tree": "40dce8c2fbc2f6e7a5bc1480763217ba2fd878ca", "parents": [ "4b4772dc4305d4c02ede9197da372ce158415100" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: remove unnecessary int returns from deferred rmap functions\n\nSource kernel commit: bc46ac64713f11c86cbbe11a86abd2a71274b15f\n\nRemove the return value from the functions that schedule deferred rmap\noperations since they never fail and do not return status.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "4b4772dc4305d4c02ede9197da372ce158415100", "tree": "b2201d15a9490850aa1ffdb822820fb7d72ab8f1", "parents": [ "9e468ed634ede66ec96c3c4e8cda0816d21fdcaa" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: remove unnecessary parameter from xfs_iext_inc_seq\n\nSource kernel commit: 2ca09177ab9dae7cc0a888137bd2421f5829cd87\n\nThis function doesn\u0027t use the @state parameter, so get rid of it.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "9e468ed634ede66ec96c3c4e8cda0816d21fdcaa", "tree": "e17f1fcaf686eb3771fb29a34750860da16dfb79", "parents": [ "6c3013adde40bf366a985c6e5e0d3d59d2d138f4" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: fix sign handling problem in xfs_bmbt_diff_two_keys\n\nSource kernel commit: b521c89027f4b86af418083cb75db60a0e7a5997\n\nIn xfs_bmbt_diff_two_keys, we perform a signed int64_t subtraction with\ntwo unsigned 64-bit quantities. If the second quantity is actually the\n\"maximum\" key (all ones) as used in _query_all, the subtraction\neffectively becomes addition of two positive numbers and the function\nreturns incorrect results. Fix this with explicit comparisons of the\nunsigned values. Nobody needs this now, but the online repair patches\nwill need this to work properly.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "6c3013adde40bf366a985c6e5e0d3d59d2d138f4", "tree": "057dce406c7ad00fa1b0f1db0c7b35b53da4d5b6", "parents": [ "781732798f9299253fc067bf0843516f87642726" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: don\u0027t return _QUERY_ABORT from xfs_rmap_has_other_keys\n\nSource kernel commit: 7380e8fec16b3527baa1153255da9cc8d5d4d309\n\nThe xfs_rmap_has_other_keys helper aborts the iteration as soon as it\nhas an answer. Don\u0027t let this abort leak out to callers.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "781732798f9299253fc067bf0843516f87642726", "tree": "7b2bb983156921a10448dcdaae9db604feb5c703", "parents": [ "763d7f0718bc491566d27db1cd29ea789b133f60" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: fix maxicount division by zero error\n\nSource kernel commit: c94613feefd7714ad0d03a1914632c15782114ff\n\nIn xfs_ialloc_setup_geometry, it\u0027s possible for a malicious/corrupt fs\nimage to set an unreasonably large value for sb_inopblog which will\ncause ialloc_blks to be zero. If sb_imax_pct is also set, this results\nin a division by zero error in the second do_div call. Therefore, force\nmaxicount to zero if ialloc_blks is zero.\n\nNote that the kernel metadata verifiers will catch the garbage inopblog\nvalue and abort the fs mount long before it tries to set up the inode\ngeometry; this is needed to avoid a crash in xfs_db while setting up the\nxfs_mount structure.\n\nFound by fuzzing sb_inopblog to 122 in xfs/350.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nReviewed-by: Carlos Maiolino \u003ccmaiolino@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "763d7f0718bc491566d27db1cd29ea789b133f60", "tree": "a6402d301359b35ae677ad7f169ff1ed3d584f1f", "parents": [ "74945501524d393ab5b3b78179f03a44ab9691c3" ], "author": { "name": "zhengbin", "email": "zhengbin13@huawei.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: remove excess function parameter description in \u0027xfs_btree_sblock_v5hdr_verify\u0027\n\nSource kernel commit: 71912e08e06b7041ba3b40945328b84798dfe6fc\n\nFixes gcc warning:\n\nfs/xfs/libxfs/xfs_btree.c:4475: warning: Excess function parameter \u0027max_recs\u0027 description in \u0027xfs_btree_sblock_v5hdr_verify\u0027\nfs/xfs/libxfs/xfs_btree.c:4475: warning: Excess function parameter \u0027pag_max_level\u0027 description in \u0027xfs_btree_sblock_v5hdr_verify\u0027\n\nFixes: c5ab131ba0df (\"libxfs: refactor short btree block verification\")\nSigned-off-by: zhengbin \u003czhengbin13@huawei.com\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "74945501524d393ab5b3b78179f03a44ab9691c3", "tree": "a7d6e2cda7af48146bf69ce4f1cc6ea0b72a27fb", "parents": [ "6cd1e6dbdc8c03f4bfb573e4cecf3b211ef90793" ], "author": { "name": "Dave Chinner", "email": "dchinner@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "xfs: add kmem allocation trace points\n\nSource kernel commit: 0ad95687c3adb91e762d0f6ea50a6b1137300e19\n\nWhen trying to correlate XFS kernel allocations to memory reclaim\nbehaviour, it is useful to know what allocations XFS is actually\nattempting. This information is not directly available from\ntracepoints in the generic memory allocation and reclaim\ntracepoints, so these new trace points provide a high level\nindication of what the XFS memory demand actually is.\n\nThere is no per-filesystem context in this code, so we just trace\nthe type of allocation, the size and the allocation constraints.\nThe kmem code also doesn\u0027t include much of the common XFS headers,\nso there are a few definitions that need to be added to the trace\nheaders and a couple of types that need to be made common to avoid\nneeding to include the whole world in the kmem code.\n\nSigned-off-by: Dave Chinner \u003cdchinner@redhat.com\u003e\nReviewed-by: Brian Foster \u003cbfoster@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "6cd1e6dbdc8c03f4bfb573e4cecf3b211ef90793", "tree": "75741898f88b03c89d8920a98c32260a3c44554c", "parents": [ "1609c11ae071e7c7b6309bf94f291faf1a2006b3" ], "author": { "name": "Tetsuo Handa", "email": "penguin-kernel@I-love.SAKURA.ne.jp", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Thu Dec 12 19:54:33 2019 -0500" }, "message": "fs: xfs: Remove KM_NOSLEEP and KM_SLEEP.\n\nSource kernel commit: 707e0ddaf67e8942448ebdd16b523e409ebe40ce\n\nSince no caller is using KM_NOSLEEP and no callee branches on KM_SLEEP,\nwe can remove KM_NOSLEEP and replace KM_SLEEP with 0.\n\nSigned-off-by: Tetsuo Handa \u003cpenguin-kernel@I-love.SAKURA.ne.jp\u003e\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "1609c11ae071e7c7b6309bf94f291faf1a2006b3", "tree": "e7976a5d4027208539cec04c2a0f9d22bd567800", "parents": [ "0f6bd6e1640c00b5e49a3462e42f6d1f4658acc6" ], "author": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 15 12:32:05 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 15 12:32:05 2019 -0500" }, "message": "xfsprogs: Release v5.3.0\n \nUpdate all the necessary files for a 5.3.0 release.\n \nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "0f6bd6e1640c00b5e49a3462e42f6d1f4658acc6", "tree": "da88b8586ef25eea9749d3251624416e2e9085f4", "parents": [ "4aaa3af15c16b30ee09be3b24f7d43dc1b326087" ], "author": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Mon Nov 11 11:31:17 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Mon Nov 11 11:31:17 2019 -0500" }, "message": "xfsprogs: Release v5.3.0-rc2\n \nUpdate all the necessary files for a 5.3.0-rc2 prerelease.\n \nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n" }, { "commit": "4aaa3af15c16b30ee09be3b24f7d43dc1b326087", "tree": "baf17b8bac3b63a1bc62cfb95acc92720d14b76c", "parents": [ "c3387fb8857bcb95ea92f3c94e682f0b483f621b" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Mon Nov 11 11:22:34 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Mon Nov 11 11:22:34 2019 -0500" }, "message": "xfs_io: fix memory leak in add_enckey\n\nInvalid arguments to add_enckey will leak the \"arg\" allocation,\nso fix that.\n\nFixes: ba71de04 (\"xfs_io/encrypt: add \u0027add_enckey\u0027 command\")\nFixes-coverity-id: 1454644\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nReviewed-by: Bill O\u0027Donnell \u003cbillodo@redhat.com\u003e\n[sandeen: incorporate improvements from Eric Biggers]\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "c3387fb8857bcb95ea92f3c94e682f0b483f621b", "tree": "457f49d87f6d882f7426bc06164750f268bb43bc", "parents": [ "baed134d7c25d0ea247046ad61cff16f19de541f" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Mon Nov 11 10:06:46 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Mon Nov 11 10:06:46 2019 -0500" }, "message": "xfs_scrub: fix complaint about uninitialized ret\n\nCoverity complained about the uninitialized ret in run_scrub_phases.\nIt\u0027s not sophisticated enough to realize that phase 1 and 7 are both\nmarked mustrun and are never the repair or datascan dummies and that\ntherefore ret is always initialized by the end of the for loop, but\nOTOH there\u0027s no reason not to fix a trivial logic bomb if that ever\nchanges.\n\nCoverity-id: 1455255\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "baed134d7c25d0ea247046ad61cff16f19de541f", "tree": "dbc7c3eb014ea5f46ed61ae9086f6e308445059f", "parents": [ "de5d20ece73f57942a68693c89edfc15969ea5ab" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:32:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:32:33 2019 -0500" }, "message": "libfrog: convert workqueue.c functions to negative error codes\n\nConvert libfrog functions to return negative error codes like libxfs\ndoes.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "de5d20ece73f57942a68693c89edfc15969ea5ab", "tree": "2f831d29c3d132ef0c3101c2ac27d994d9f4bc37", "parents": [ "2f4422f4be9c805d6607a1e2ac13160ade93d110" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:32:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:32:33 2019 -0500" }, "message": "libfrog: convert scrub.c functions to negative error codes\n\nConvert libfrog functions to return negative error codes like libxfs\ndoes.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "2f4422f4be9c805d6607a1e2ac13160ade93d110", "tree": "48963e1339ddb641444abf84dd57fc7e3f89cdcf", "parents": [ "e6542132dec3cdd216e45d086dcee8b7ce6691ec" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:32:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:32:33 2019 -0500" }, "message": "libfrog: convert ptvar.c functions to negative error codes\n\nConvert libfrog functions to return negative error codes like libxfs\ndoes.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "e6542132dec3cdd216e45d086dcee8b7ce6691ec", "tree": "d1f4b1722ad6b37904c3a697b2322984866bee41", "parents": [ "03d96c642d5973e24a84114dd40b4886ee1c9031" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:32:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:32:33 2019 -0500" }, "message": "libfrog: convert bulkstat.c functions to negative error codes\n\nConvert libfrog functions to return negative error codes like libxfs\ndoes.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "03d96c642d5973e24a84114dd40b4886ee1c9031", "tree": "1dbfbce3983efbbacd88689b5623c40d2671e19f", "parents": [ "93d69bc79314f7c3f1404123355056f9ed2068a2" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:32:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:32:33 2019 -0500" }, "message": "libfrog: convert fsgeom.c functions to negative error codes\n\nConvert libfrog functions to return negative error codes like libxfs\ndoes.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "93d69bc79314f7c3f1404123355056f9ed2068a2", "tree": "594fd10b44fd8be9dd65887486b79a4ee1a82d7a", "parents": [ "9fc3ef62c98f7dc3c6f15cf3efb9421085790d29" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:32:33 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:32:33 2019 -0500" }, "message": "libfrog: convert bitmap.c to negative error codes\n\nConvert libfrog functions to return negative error codes like libxfs\ndoes.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "9fc3ef62c98f7dc3c6f15cf3efb9421085790d29", "tree": "3b3c216361adaf9f90878edcc9c568da8f57a56d", "parents": [ "64dabc9fa59439b1737fc81e1aa1f59637df3066" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:31:06 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:31:06 2019 -0500" }, "message": "libfrog: print library errors\n\nAdd a libfrog library function that will print tagged error messages.\nThis will eliminate the need for a lot of open-coded:\n\nerrno \u003d ret;\nperror(\"...\");\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "64dabc9fa59439b1737fc81e1aa1f59637df3066", "tree": "2b0df42b7dafdb06f46d6dab4a7ef91ec7433e01", "parents": [ "b8e62724da7b32d04e10d5ec23ef8a480cb9d61e" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:30:57 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:30:57 2019 -0500" }, "message": "xfs_scrub: remove moveon from main program\n\nReplace the moveon returns in xfs_scrub.c to e with a direct integer\nerror return.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "b8e62724da7b32d04e10d5ec23ef8a480cb9d61e", "tree": "02a5a43f3ca364c0f8b2a9d2f936ad5ff5c20d35", "parents": [ "35b65bcfff84ea7fed36dd5f7fec906d595103c1" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:30:36 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:30:36 2019 -0500" }, "message": "xfs_scrub: remove XFS_ITERATE_INODES_ABORT from inode iterator\n\nRemove the _ABORT code since nobody uses it and we\u0027re slowly moving to\nECANCELED anyway.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "35b65bcfff84ea7fed36dd5f7fec906d595103c1", "tree": "d06df7530da8a288934f15b48f18512098c0ea72", "parents": [ "f29dc2f55a4f5ea40a2e5951d3587adc3f2364e0" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:30:29 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:30:29 2019 -0500" }, "message": "xfs_scrub: remove moveon from phase 1 functions\n\nReplace the moveon returns in the phase 1 code with a direct integer\nerror return.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "f29dc2f55a4f5ea40a2e5951d3587adc3f2364e0", "tree": "b3920fb8779eee69f47ec36680af66455d3c43d1", "parents": [ "df0241036697e1cdebe2ba0b3f3ba8529bdcaf2d" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:30:22 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:30:22 2019 -0500" }, "message": "xfs_scrub: remove moveon from phase 2 functions\n\nReplace the moveon returns in the phase 2 code with a direct integer\nerror return.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "df0241036697e1cdebe2ba0b3f3ba8529bdcaf2d", "tree": "aacc3e5335d793a30ea425ba5cad769316d90dda", "parents": [ "596a30ba6096d349432537182a6fef09837591e5" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:30:16 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:30:16 2019 -0500" }, "message": "xfs_scrub: remove moveon from phase 3 functions\n\nReplace the moveon returns in the phase 3 code with a direct integer\nerror return.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "596a30ba6096d349432537182a6fef09837591e5", "tree": "266c543e89ea0150f1e8e227f8bb45a5de5b3cb8", "parents": [ "8142c597659f82e0099516ac0cbe2408fbd77ddb" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:30:09 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:30:09 2019 -0500" }, "message": "xfs_scrub: remove moveon from phase 4 functions\n\nReplace the moveon returns in the phase 4 code with a direct integer\nerror return.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "8142c597659f82e0099516ac0cbe2408fbd77ddb", "tree": "7aba4519490650dd410afcf7fb5a69100f5acce5", "parents": [ "af9eb208f6b0bf5ac37662bc2557a57808f26daa" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:30:03 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:30:03 2019 -0500" }, "message": "xfs_scrub: remove moveon from phase 5 functions\n\nReplace the moveon returns in the phase 5 code with a direct integer\nerror return.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "af9eb208f6b0bf5ac37662bc2557a57808f26daa", "tree": "2d02cfa1cc286094ba44f890109795f1933370ca", "parents": [ "0d96df9d3f2baf7a674741b93ddcb09a772d7628" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:29:55 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:29:55 2019 -0500" }, "message": "xfs_scrub: remove moveon from phase 6 functions\n\nReplace the moveon returns in the phase 6 code with a direct integer\nerror return.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "0d96df9d3f2baf7a674741b93ddcb09a772d7628", "tree": "9876bcdaa40d15b5ee46281e2602ac8acc213c3f", "parents": [ "83d2c80b939a2f5060bd247684d14e790d070746" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:29:47 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:29:47 2019 -0500" }, "message": "xfs_scrub: remove moveon from phase 7 functions\n\nReplace the moveon returns in the phase 7 code with a direct integer\nerror return.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n" }, { "commit": "83d2c80b939a2f5060bd247684d14e790d070746", "tree": "94b96078882225c9f8c31fffdda55203d3da8549", "parents": [ "d22f24718e4669d6b8d239df3d162e47af77cd8b" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:29:29 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:29:29 2019 -0500" }, "message": "xfs_scrub: remove moveon from repair action list helpers\n\nReplace the moveon returns in the repair action list processing\nfunctions with a direct integer error return.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "d22f24718e4669d6b8d239df3d162e47af77cd8b", "tree": "dee043a5bc63923a4104fa2e51dc8f53bf4023aa", "parents": [ "d86e83b87fe48325adc4031cc98b6bb9f687ce24" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:29:22 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:29:22 2019 -0500" }, "message": "xfs_scrub: remove moveon from scrub ioctl wrappers\n\nReplace the moveon returns in the scrub ioctl wrapper functions\nwith a direct integer error return.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "d86e83b87fe48325adc4031cc98b6bb9f687ce24", "tree": "9236df02113b66191268fbb018d641df2db9c97c", "parents": [ "ac1c1f8e68a83f0ec0a969ec75464c9f9df9967b" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:29:15 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:29:15 2019 -0500" }, "message": "xfs_scrub: remove moveon from progress report helpers\n\nReplace the moveon returns in the scrub process reporting helpers\nwith a direct integer error return.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "ac1c1f8e68a83f0ec0a969ec75464c9f9df9967b", "tree": "7e4c801e4a7b415f6550764e40956950f1da86b0", "parents": [ "7a2eef2b2cede76f4e8c02776c28af37a01f799c" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:29:08 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:29:08 2019 -0500" }, "message": "xfs_scrub: remove moveon from unicode name collision helpers\n\nReplace the moveon returns in the unicode name collsion detector code\nwith a direct integer error return.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "7a2eef2b2cede76f4e8c02776c28af37a01f799c", "tree": "651bbbdc7121ecb314f7d695905695c93cae06e5", "parents": [ "f544ec318d83492350270f4c8b4d5454ce3e7b84" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:28:45 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:28:45 2019 -0500" }, "message": "xfs_scrub: remove moveon from spacemap\n\nReplace the moveon returns in the space map iteration code with a direct\ninteger return.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "f544ec318d83492350270f4c8b4d5454ce3e7b84", "tree": "f704e1d227769dfd879faab2179d9d0d821c7696", "parents": [ "59f79e0aef94d33db2846580c27319fa5e3beaea" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:28:37 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:28:37 2019 -0500" }, "message": "xfs_scrub: remove moveon from vfs directory tree iteration\n\nReplace the moveon returns in the vfs directory tree walking functions\nwith a direct integer error return.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "59f79e0aef94d33db2846580c27319fa5e3beaea", "tree": "c708373f96632507fce109a5b739fa0f776d9844", "parents": [ "934d8d3af858d63cea110c71a90e7e2b28f48172" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:28:21 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:28:21 2019 -0500" }, "message": "xfs_scrub: remove moveon from inode iteration\n\nReplace the moveon retuns in the inode iteration functions with a direct\ninteger error return. While we\u0027re at it, drop the xfs_ prefix.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "934d8d3af858d63cea110c71a90e7e2b28f48172", "tree": "a72d94ec9dabc02030d3d259ef3c8b2f8cac3cce", "parents": [ "73ce96690eb4d8a5b65b74f61cc26987323642db" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:27:19 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:27:19 2019 -0500" }, "message": "xfs_scrub: remove moveon from the fscounters functions\n\nReplace the moveon returns in the fscounters functions with direct error\nreturns. Drop the xfs_ prefixes while we\u0027re at it.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n" }, { "commit": "73ce96690eb4d8a5b65b74f61cc26987323642db", "tree": "1b22601e9cc99bcc9f09a0c9da14426d7081e42a", "parents": [ "16dbab1a1f8afff574273e7771d9f15300a6dc26" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:27:17 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:27:17 2019 -0500" }, "message": "xfs_scrub: remove moveon from filemap iteration\n\nRemove the moveon and descr clutter from filemap iteration in favor of\nreturning errors directly and passing error domain descriptions around\nthrough the existing void *arg.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "16dbab1a1f8afff574273e7771d9f15300a6dc26", "tree": "86d3cce38008ed5b0f2556af746f611ece2d1c19", "parents": [ "a3158a7542f39f32c9c1b389edd85e7c46c95b96" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:27:06 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:27:06 2019 -0500" }, "message": "xfs_scrub: implement background mode for phase 6\n\nPhase 6 doesn\u0027t implement background mode, which means that it doesn\u0027t\nrun in single-threaded mode with one -b and it doesn\u0027t sleep between\ncalls with multiple -b like every other phase does. It also doesn\u0027t\nrestrict the amount of work per kernel call, which is a key part of\nthrottling. Wire up the necessary pieces to make it behave like the man\npage says it should.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Allison Collins \u003callison.henderson@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "a3158a7542f39f32c9c1b389edd85e7c46c95b96", "tree": "056fa8266d79bf7582e780b161109e2e7cf6a889", "parents": [ "b3f76f943479410f328eb599c45a18abdf25f9b4" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:27:04 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:27:04 2019 -0500" }, "message": "xfs_scrub: adapt phase5 to deferred descriptions\n\nApply the deferred description mechanism to phase 5 so that we don\u0027t\nbuild inode prefix strings unless we actually want to say something\nabout an inode\u0027s attributes or directory entries.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "b3f76f943479410f328eb599c45a18abdf25f9b4", "tree": "c58251d87264e15c751424603670634f558449f8", "parents": [ "51c940530e315a65a76ac6936893b4449cfbd5c8" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:27:02 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:27:02 2019 -0500" }, "message": "xfs_scrub: implement deferred description string rendering\n\nA flamegraph analysis of xfs_scrub runtimes showed that we spend 7-10%\nof the program\u0027s userspace runtime rendering prefix strings in case we\nwant to show a message about something we\u0027re checking, whether or not\nthat string ever actually gets used.\n\nFor a non-verbose run on a clean filesystem, this work is totally\nunnecessary. We could defer the message catalog lookup and snprintf\ncall until we actually need that message, so build enough of a function\nclosure mechanism so that we can capture some location information when\nits convenient and push that all the way to the edge of the call graph\nand only when we need it.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\n[sandeen: make comment change suggested on list]\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "51c940530e315a65a76ac6936893b4449cfbd5c8", "tree": "e172ebc9e06d824b249024c65fd2263d660f2647", "parents": [ "89f0bc44fd697b511200ca27c08b1d2638a6ba50" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Wed Nov 06 17:26:35 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:26:35 2019 -0500" }, "message": "xfs_scrub: bump work_threads to include the controller thread\n\nBump @work_threads in the scrub phase setup function because we will\nsoon want the main thread (i.e. the one that coordinates workers) to be\nfactored into per-thread data structures. We\u0027ll need this in an\nupcoming patch to render error string prefixes to preallocated\nper-thread buffers.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "89f0bc44fd697b511200ca27c08b1d2638a6ba50", "tree": "d05b140a7455c55ac92e6f52b226497b99378171", "parents": [ "7e8275f8939988f18f9a4a596381ca215fde2270" ], "author": { "name": "Amir Goldstein", "email": "amir73il@gmail.com", "time": "Wed Nov 06 17:26:29 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Wed Nov 06 17:26:29 2019 -0500" }, "message": "xfs_io/lsattr: expose FS_XFLAG_HASATTR flag\n\nFor efficient check if file has xattrs.\n\nSigned-off-by: Amir Goldstein \u003camir73il@gmail.com\u003e\n[sandeen: Add commented-out option to CHATTR_XFLAG_LIST]\nReviewed-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "7e8275f8939988f18f9a4a596381ca215fde2270", "tree": "7eabc9fae1c0a15ae965a609cd0f653a5fe95bda", "parents": [ "49e05cb05113c8afdbc975dec8f1bd6e94a42395" ], "author": { "name": "Eric Sandeen", "email": "sandeen@redhat.com", "time": "Mon Nov 04 15:35:49 2019 -0500" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Mon Nov 04 15:35:49 2019 -0500" }, "message": "xfs_growfs: allow mounted device node as argument\n\nUp until:\n\n b97815a0 xfs_growfs: ensure target path is an active xfs mountpoint\n\nxfs_growfs actually accepted a mounted block device name as the\nprimary argument, because it could be found in the mount table.\n\nIt turns out that Ansible was making use of this undocumented behavior,\nand it\u0027s trivial to allow it, so put it back in place and document\nit this time.\n\nSigned-off-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nReviewed-by: Christoph Hellwig \u003chch@lst.de\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "49e05cb05113c8afdbc975dec8f1bd6e94a42395", "tree": "84cd1dd545e830b74154e46abc27d2cbd58c7695", "parents": [ "059215441a51dadb78afd0daed31c896bac22870" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 18:04:21 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 18:04:21 2019 -0400" }, "message": "xfs_scrub: create a new category for unfixable errors\n\nThere\u0027s nothing that xfs_scrub (or XFS) can do about media errors for\ndata file blocks -- the data are gone. Create a new category for these\nunfixable errors so that we don\u0027t advise the user to take further action\nthat won\u0027t fix the problem.\n\n[sandeen: this error counter is only used for media errors today, but\nthere are tests in the code to accommodate potential future new types\nof unfixable errors.]\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\n" }, { "commit": "059215441a51dadb78afd0daed31c896bac22870", "tree": "b669c4ac23aa574695814d29b93f34428998ec04", "parents": [ "e458f3f13e678e48549cf03bef92a13b88d7f17f" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 17:58:14 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 17:58:14 2019 -0400" }, "message": "xfs_scrub: refactor xfs_scrub_excessive_errors\n\nRefactor this helper to avoid cycling the scrub context lock when the\nuser hasn\u0027t configured a maximum error count threshold.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\n[sandeen: don\u0027t check unsigned max_errors for \u003c 0]\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "e458f3f13e678e48549cf03bef92a13b88d7f17f", "tree": "f915946e969ed58ad4be22718e924ae729d3c063", "parents": [ "abc2e70db965430c8d83d8b76070cc75066dfe9f" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 17:55:06 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 17:55:06 2019 -0400" }, "message": "xfs_scrub: promote some of the str_info to str_error calls\n\nNow that str_error is only for runtime errors, we can promote a few of\nthe str_info calls that report runtime errors to str_error.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "abc2e70db965430c8d83d8b76070cc75066dfe9f", "tree": "17ddf15e5500aa8ab16cfc730ea86d6a6fa88431", "parents": [ "420fad2d3d5d0b27c06d2431139d1b62a0f705d2" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 17:55:06 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 17:55:06 2019 -0400" }, "message": "xfs_scrub: explicitly track corruptions, not just errors\n\nRename the @errors_found variable to @corruptions_found to make it\nmore explicit that we\u0027re tracking fs corruption issues. Add a new\nstr_corrupt() function to handle communications that fall under this new\ncorruption classification. str_error() now exists to log runtime errors\nthat do not have an associated errno code.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "420fad2d3d5d0b27c06d2431139d1b62a0f705d2", "tree": "c1ee0a8da9cfd834e72f4a69660a766fb0fb99f2", "parents": [ "5155653f70bc87fcb8d14320e17c311e502e7388" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 17:55:06 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 17:55:06 2019 -0400" }, "message": "xfs_scrub: clean up error level table\n\nRework the error levels table in preparation for adding a few more error\ncategories that won\u0027t fit on a single line.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "5155653f70bc87fcb8d14320e17c311e502e7388", "tree": "63b0d2d643a0ca91e2900053d948f73a2c66fb08", "parents": [ "e98616ba9dc9bc457dcc111f97b33a88c6221850" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 17:55:06 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 17:55:06 2019 -0400" }, "message": "xfs_scrub: simplify post-run reporting logic\n\nSimplify the post-run error and warning reporting logic so that in\nsubsequent patches we can be more specific about what types of things\nwent wrong.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "e98616ba9dc9bc457dcc111f97b33a88c6221850", "tree": "830e6a2673221dc72dabce9a302eacef390f76af", "parents": [ "e3724c8b82a3206284c16b26d3676aaa1b5f7528" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 17:55:06 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 17:55:06 2019 -0400" }, "message": "xfs_scrub: fix misclassified error reporting\n\nFix a few places where we assign error reports to the wrong\nclassification.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "e3724c8b82a3206284c16b26d3676aaa1b5f7528", "tree": "d63508c00d9333168f81a81c0c8d12a621882153", "parents": [ "ae14fe63b522e25b4652683d3fde54ce415fa80b" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:55:28 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:55:28 2019 -0400" }, "message": "xfs_scrub: refactor xfs_iterate_inodes_range_check\n\nMove all the bulkstat action into a single helper function. This gets\nrid of the awkward name and increases cohesion.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "ae14fe63b522e25b4652683d3fde54ce415fa80b", "tree": "914e39892ee7cfde9573cb6b1fa69ff4fc06f3bc", "parents": [ "b658de931769b85dd9145249ba4c8acf6ebbc863" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:54:20 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:54:20 2019 -0400" }, "message": "xfs_scrub: clean out the nproc global variable\n\nGet rid of this global variable since we already have a libfrog function\nthat does exactly what it does.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "b658de931769b85dd9145249ba4c8acf6ebbc863", "tree": "92fd181e5d8e994a383bf750b10cbe657e9bfb28", "parents": [ "4e5fe12368f9d8670d9516ab8e02827980775e5c" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:38:35 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:38:35 2019 -0400" }, "message": "libfrog: take over platform headers\n\nMove all the declarations for platform-specific functions into\nlibfrog/platform.h, since they\u0027re a part of libfrog now.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "4e5fe12368f9d8670d9516ab8e02827980775e5c", "tree": "2ea20d0dd60cc446e77a10ee6522779c66df6862", "parents": [ "4b45ff6fa6fc1e28b270cc910daf7763fa35c0fb" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:38:35 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:38:35 2019 -0400" }, "message": "libxfs: remove libxfs_physmem\n\nRemove this thin wrapper too.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "4b45ff6fa6fc1e28b270cc910daf7763fa35c0fb", "tree": "05992b4c6bf2f78f9dedfeb9dd50b8485f0a9fe7", "parents": [ "d530e5890818577a7588f8e6dd1c3741c8536a02" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:38:35 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:38:35 2019 -0400" }, "message": "libxfs: remove libxfs_nproc\n\nRemove libxfs_nproc since it\u0027s a wrapper around a libfrog function.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "d530e5890818577a7588f8e6dd1c3741c8536a02", "tree": "e36bdd9e828025d213949725d7336c90eddf2617", "parents": [ "eacea7078cc22d42ab8c080da5c3761f78aaf55e" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:38:35 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:38:35 2019 -0400" }, "message": "libfrog: clean up platform_nproc\n\nThe platform_nproc function should check for error returns and obviously\ngarbage values and deal with them appropriately. Fix the header\ndeclaration since it\u0027s part of the libfrog platform support code, not\nlibxfs. xfs_scrub will make use of it in the next patch.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "eacea7078cc22d42ab8c080da5c3761f78aaf55e", "tree": "27316a10c77fb10a8a6627fbbd676a0439529f68", "parents": [ "0f402dd89532e99804fcf733bd1a9c22513fced8" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:32:45 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:32:45 2019 -0400" }, "message": "xfs_scrub: fix media verification thread pool size calculations\n\nThe read verifier pool deals with two different thread counts -- there\u0027s\nthe submitter thread count that enables us to perform per-thread verify\nrequest aggregation, and then there\u0027s the io thread pool count which is\nthe maximum number of IO requests we want to send to the disk at any\ngiven time.\n\nThe io thread pool count should be derived from disk_heads() but instead\nwe bungle it by measuring and modifying(!) the nproc global variable.\nFix the derivation to use global variables correctly.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "0f402dd89532e99804fcf733bd1a9c22513fced8", "tree": "8ebb963df29702c38062714788d7b8b7a17507e6", "parents": [ "c9b349bde09807f641af9180d6c672ae699e6e08" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:32:45 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:32:45 2019 -0400" }, "message": "xfs_scrub: request fewer bmaps when we can\n\nIn xfs_iterate_filemaps, we query the number of bmaps for a given file\nthat we\u0027re going to iterate, so feed that information to bmap so that\nthe kernel won\u0027t waste time allocating in-kernel memory unnecessarily.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "c9b349bde09807f641af9180d6c672ae699e6e08", "tree": "a940fa1049e2115465a0746767c2da5e1b9e554a", "parents": [ "909c6a54c3639b3c9f288e2b3bb21ac4f765a304" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:29:57 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:29:57 2019 -0400" }, "message": "xfs_scrub: reduce fsmap activity for media errors\n\nRight now we rather foolishly query the fsmap data for every single\nmedia error that we find. This is a silly waste of time since we\nhave yet to combine adjacent bad blocks into bad extents, so move the\nrmap query until after we\u0027ve constructed the bad block bitmap data.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n" }, { "commit": "909c6a54c3639b3c9f288e2b3bb21ac4f765a304", "tree": "cadc243a5ab5d05b05efd707cbe48c8d7688afa0", "parents": [ "02d0069ed81b6a191d43ca2e776cc0fdcb025df3" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:16:40 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:16:40 2019 -0400" }, "message": "xfs_scrub: don\u0027t report media errors on unwritten extents\n\nDon\u0027t report media errors for unwritten extents since no data has been\nlost.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "02d0069ed81b6a191d43ca2e776cc0fdcb025df3", "tree": "66567b88019c83e209b1b89ab8614a9349542851", "parents": [ "f1f5fd3a7a84969c40c9f06197bebb4cd8e47b15" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:16:40 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:16:40 2019 -0400" }, "message": "xfs_scrub: improve reporting of file metadata media errors\n\nReport media errors that map to data and attr fork extent maps.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "f1f5fd3a7a84969c40c9f06197bebb4cd8e47b15", "tree": "ec4a9f9ebdfa12ae5962e6bf257208c208e038de", "parents": [ "ed953d262b014b3a8bcdf23ce00cf0c722490eec" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:16:40 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:16:40 2019 -0400" }, "message": "xfs_scrub: better reporting of metadata media errors\n\nWhen we report bad metadata, we inexplicably report the physical address\nin units of sectors, whereas for file data we report file offsets in\nunits of bytes. Fix the metadata reporting units to match the file data\nunits (i.e. bytes) and skip the printf for all other cases.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "ed953d262b014b3a8bcdf23ce00cf0c722490eec", "tree": "2c304d030448bfe978d666d6fe31155b9ddf23a5", "parents": [ "663e02a090c82391bd3fdb861b8fceba7f051726" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:16:40 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:16:40 2019 -0400" }, "message": "xfs_scrub: improve reporting of file data media errors\n\nWhen we report media errors, we should tell the administrator the file\noffset and length of the bad region, not just the offset of the entire\nfile extent record that overlaps a bad region.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "663e02a090c82391bd3fdb861b8fceba7f051726", "tree": "7db2c063d1c87c110a787d834adae77a3d607315", "parents": [ "aeff064126ede3d7eef1e7120f93c71a35fe2b73" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:16:40 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:16:40 2019 -0400" }, "message": "xfs_scrub: separate media error reporting for attribute forks\n\nUse different functions to warn about media errors that were detected in\nunderlying xattr data because logical offsets for attribute fork extents\nhave no meaning to users.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" }, { "commit": "aeff064126ede3d7eef1e7120f93c71a35fe2b73", "tree": "f1f2144ab35f0c6502134ddbdc0e962f997ec908", "parents": [ "5770b2f08d4ce8bf0c2f1708ff3937fce4f202cd" ], "author": { "name": "Darrick J. Wong", "email": "darrick.wong@oracle.com", "time": "Fri Nov 01 16:16:40 2019 -0400" }, "committer": { "name": "Eric Sandeen", "email": "sandeen@sandeen.net", "time": "Fri Nov 01 16:16:40 2019 -0400" }, "message": "libfrog/xfs_scrub: improve iteration function documentation\n\nBetween libfrog and xfs_scrub, we have several item collection iteration\nfunctions that take a pointer to a function that will be called for\nevery item in that collection. They\u0027re not well documented, so improve\nthe description of when they\u0027ll be called and what kinds of return\nvalues they expect.\n\nSigned-off-by: Darrick J. Wong \u003cdarrick.wong@oracle.com\u003e\nReviewed-by: Eric Sandeen \u003csandeen@redhat.com\u003e\nSigned-off-by: Eric Sandeen \u003csandeen@sandeen.net\u003e\n\n" } ], "next": "5770b2f08d4ce8bf0c2f1708ff3937fce4f202cd" }