| From 5731afb0e8aa7ed75f66a5190b80f9dae0120ca3 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 21 Nov 2022 01:22:01 +0100 |
| Subject: ca8210: Fix crash by zero initializing data |
| |
| From: Hauke Mehrtens <hauke@hauke-m.de> |
| |
| [ Upstream commit 1e24c54da257ab93cff5826be8a793b014a5dc9c ] |
| |
| The struct cas_control embeds multiple generic SPI structures and we |
| have to make sure these structures are initialized to default values. |
| This driver does not set all attributes. When using kmalloc before some |
| attributes were not initialized and contained random data which caused |
| random crashes at bootup. |
| |
| Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") |
| Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> |
| Link: https://lore.kernel.org/r/20221121002201.1339636-1-hauke@hauke-m.de |
| Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ieee802154/ca8210.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c |
| index 450b16ad40a4..e1a569b99e4a 100644 |
| --- a/drivers/net/ieee802154/ca8210.c |
| +++ b/drivers/net/ieee802154/ca8210.c |
| @@ -885,7 +885,7 @@ static int ca8210_spi_transfer( |
| |
| dev_dbg(&spi->dev, "%s called\n", __func__); |
| |
| - cas_ctl = kmalloc(sizeof(*cas_ctl), GFP_ATOMIC); |
| + cas_ctl = kzalloc(sizeof(*cas_ctl), GFP_ATOMIC); |
| if (!cas_ctl) |
| return -ENOMEM; |
| |
| -- |
| 2.35.1 |
| |
