| From stable-bounces@linux.kernel.org Wed Mar 7 13:37:59 2007 |
| From: Patrick McHardy <kaber@trash.net> |
| Date: Wed, 7 Mar 2007 22:34:45 +0100 (MET) |
| Subject: nfnetlink_log: fix crash on bridged packet |
| To: stable@kernel.org |
| Cc: netfilter-devel@lists.netfilter.org, Patrick McHardy <kaber@trash.net>, <davem@davemloft.net> |
| Message-ID: <20070307213405.22306.94073.sendpatchset@localhost.localdomain> |
| |
| From: Patrick McHardy <kaber@trash.net> |
| |
| [NETFILTER]: nfnetlink_log: fix crash on bridged packet |
| |
| physoutdev is only set on purely bridged packet, when nfnetlink_log is used |
| in the OUTPUT/FORWARD/POSTROUTING hooks on packets forwarded from or to a |
| bridge it crashes when trying to dereference skb->nf_bridge->physoutdev. |
| |
| Reported by Holger Eitzenberger <heitzenberger@astaro.com> |
| |
| Signed-off-by: Patrick McHardy <kaber@trash.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| net/netfilter/nfnetlink_log.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/net/netfilter/nfnetlink_log.c |
| +++ b/net/netfilter/nfnetlink_log.c |
| @@ -491,7 +491,7 @@ __build_packet_message(struct nfulnl_ins |
| * for physical device (when called from ipv4) */ |
| NFA_PUT(inst->skb, NFULA_IFINDEX_OUTDEV, |
| sizeof(tmp_uint), &tmp_uint); |
| - if (skb->nf_bridge) { |
| + if (skb->nf_bridge && skb->nf_bridge->physoutdev) { |
| tmp_uint = |
| htonl(skb->nf_bridge->physoutdev->ifindex); |
| NFA_PUT(inst->skb, NFULA_IFINDEX_PHYSOUTDEV, |
