| From 483c319188c74e82b29a0ed7a7fa7065570f2193 Mon Sep 17 00:00:00 2001 |
| From: Mika Westerberg <mika.westerberg@linux.intel.com> |
| Date: Mon, 13 Jan 2014 11:17:04 +0200 |
| Subject: spi/pxa2xx: initialize DMA channels to -1 to prevent inadvertent match |
| |
| From: Mika Westerberg <mika.westerberg@linux.intel.com> |
| |
| commit 483c319188c74e82b29a0ed7a7fa7065570f2193 upstream. |
| |
| Commit cddb339badb0 (spi/pxa2xx: convert to dma_request_slave_channel_compat()) |
| converted the driver to use ACPI provided DMA helpers but it forgot to |
| initialize the platform data for the channels to -1. Failing to do so will |
| result inadvertent match in the filter function because 0 is a valid |
| channel number. |
| |
| Prevent this from happening by initializing both platform data channels |
| correctly to -1. |
| |
| Fixes: cddb339badb0 (spi/pxa2xx: convert to dma_request_slave_channel_compat()) |
| Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> |
| Signed-off-by: Mark Brown <broonie@linaro.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/spi/spi-pxa2xx.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- a/drivers/spi/spi-pxa2xx.c |
| +++ b/drivers/spi/spi-pxa2xx.c |
| @@ -1066,6 +1066,8 @@ pxa2xx_spi_acpi_get_pdata(struct platfor |
| |
| pdata->num_chipselect = 1; |
| pdata->enable_dma = true; |
| + pdata->tx_chan_id = -1; |
| + pdata->rx_chan_id = -1; |
| |
| return pdata; |
| } |