| From a87783699b23395c46bbeeb5d28f6db24897bf26 Mon Sep 17 00:00:00 2001 |
| From: Emmanuel Grumbach <emmanuel.grumbach@intel.com> |
| Date: Wed, 22 May 2013 10:48:10 +0300 |
| Subject: iwlwifi: dvm: fix zero LQ CMD sending avoidance |
| |
| From: Emmanuel Grumbach <emmanuel.grumbach@intel.com> |
| |
| commit a87783699b23395c46bbeeb5d28f6db24897bf26 upstream. |
| |
| In 63b77bf489881747c5118476918cc8c29378ee63 |
| |
| iwlwifi: dvm: don't send zeroed LQ cmd |
| |
| I tried to avoid to send zeroed LQ cmd, but I made a (very) |
| stupid mistake in the memcmp. |
| Since this patch has been ported to stable, the fix should |
| go to stable too. |
| |
| This fixes https://bugzilla.kernel.org/show_bug.cgi?id=58341 |
| |
| Reported-by: Hinnerk van Bruinehsen <h.v.bruinehsen@fu-berlin.de> |
| Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> |
| Signed-off-by: Johannes Berg <johannes.berg@intel.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/net/wireless/iwlwifi/dvm/sta.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/net/wireless/iwlwifi/dvm/sta.c |
| +++ b/drivers/net/wireless/iwlwifi/dvm/sta.c |
| @@ -735,7 +735,7 @@ void iwl_restore_stations(struct iwl_pri |
| memcpy(&lq, priv->stations[i].lq, |
| sizeof(struct iwl_link_quality_cmd)); |
| |
| - if (!memcmp(&lq, &zero_lq, sizeof(lq))) |
| + if (memcmp(&lq, &zero_lq, sizeof(lq))) |
| send_lq = true; |
| } |
| spin_unlock_bh(&priv->sta_lock); |