| From 09b6cafa627c6f3a7351fc8e9878aac0ee18c39d Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sat, 30 Apr 2022 12:33:18 -0700 |
| Subject: ALSA: hda - fix unused Realtek function when PM is not enabled |
| |
| From: Randy Dunlap <rdunlap@infradead.org> |
| |
| [ Upstream commit c3d9ca93f1e3bd3d1adfc4479a12c82fed424c87 ] |
| |
| When CONFIG_PM is not enabled, alc_shutup() is not needed, |
| so move it inside the #ifdef CONFIG_PM guard. |
| Also drop some contiguous #endif / #ifdef CONFIG_PM for simplicity. |
| |
| Fixes this build warning: |
| sound/pci/hda/patch_realtek.c:886:20: warning: unused function 'alc_shutup' |
| |
| Fixes: 08c189f2c552 ("ALSA: hda - Use generic parser codes for Realtek driver") |
| Signed-off-by: Randy Dunlap <rdunlap@infradead.org> |
| Reported-by: kernel test robot <lkp@intel.com> |
| Link: https://lore.kernel.org/r/20220430193318.29024-1-rdunlap@infradead.org |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| sound/pci/hda/patch_realtek.c | 8 +++----- |
| 1 file changed, 3 insertions(+), 5 deletions(-) |
| |
| diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c |
| index 779205bf5862..e38acdbe1a3b 100644 |
| --- a/sound/pci/hda/patch_realtek.c |
| +++ b/sound/pci/hda/patch_realtek.c |
| @@ -937,6 +937,9 @@ static int alc_init(struct hda_codec *codec) |
| return 0; |
| } |
| |
| +#define alc_free snd_hda_gen_free |
| + |
| +#ifdef CONFIG_PM |
| static inline void alc_shutup(struct hda_codec *codec) |
| { |
| struct alc_spec *spec = codec->spec; |
| @@ -950,9 +953,6 @@ static inline void alc_shutup(struct hda_codec *codec) |
| alc_shutup_pins(codec); |
| } |
| |
| -#define alc_free snd_hda_gen_free |
| - |
| -#ifdef CONFIG_PM |
| static void alc_power_eapd(struct hda_codec *codec) |
| { |
| alc_auto_setup_eapd(codec, false); |
| @@ -966,9 +966,7 @@ static int alc_suspend(struct hda_codec *codec) |
| spec->power_hook(codec); |
| return 0; |
| } |
| -#endif |
| |
| -#ifdef CONFIG_PM |
| static int alc_resume(struct hda_codec *codec) |
| { |
| struct alc_spec *spec = codec->spec; |
| -- |
| 2.35.1 |
| |