| From cb824baf3b18239ebec569adccc79b8542fdbe5a Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 17 Mar 2022 13:16:13 +0000 |
| Subject: crypto: stm32 - fix reference leak in stm32_crc_remove |
| |
| From: Zheng Yongjun <zhengyongjun3@huawei.com> |
| |
| [ Upstream commit e9a36feecee0ee5845f2e0656f50f9942dd0bed3 ] |
| |
| pm_runtime_get_sync() will increment pm usage counter even it |
| failed. Forgetting to call pm_runtime_put_noidle will result |
| in reference leak in stm32_crc_remove, so we should fix it. |
| |
| Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> |
| Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/crypto/stm32/stm32-crc32.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/crypto/stm32/stm32-crc32.c b/drivers/crypto/stm32/stm32-crc32.c |
| index fb640e0ea614..2ecc970f5cae 100644 |
| --- a/drivers/crypto/stm32/stm32-crc32.c |
| +++ b/drivers/crypto/stm32/stm32-crc32.c |
| @@ -332,8 +332,10 @@ static int stm32_crc_remove(struct platform_device *pdev) |
| struct stm32_crc *crc = platform_get_drvdata(pdev); |
| int ret = pm_runtime_get_sync(crc->dev); |
| |
| - if (ret < 0) |
| + if (ret < 0) { |
| + pm_runtime_put_noidle(crc->dev); |
| return ret; |
| + } |
| |
| spin_lock(&crc_list.lock); |
| list_del(&crc->list); |
| -- |
| 2.35.1 |
| |
