| From 02233f5e011ed127133644dc347b844236bd5bc2 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 20 Mar 2022 21:56:38 -0700 |
| Subject: Input: stmfts - fix reference leak in stmfts_input_open |
| |
| From: Zheng Yongjun <zhengyongjun3@huawei.com> |
| |
| [ Upstream commit 26623eea0da3476446909af96c980768df07bbd9 ] |
| |
| pm_runtime_get_sync() will increment pm usage counter even it |
| failed. Forgetting to call pm_runtime_put_noidle will result |
| in reference leak in stmfts_input_open, so we should fix it. |
| |
| Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> |
| Link: https://lore.kernel.org/r/20220317131604.53538-1-zhengyongjun3@huawei.com |
| Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/input/touchscreen/stmfts.c | 8 +++++--- |
| 1 file changed, 5 insertions(+), 3 deletions(-) |
| |
| diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c |
| index cd8805d71d97..be1dd504d5b1 100644 |
| --- a/drivers/input/touchscreen/stmfts.c |
| +++ b/drivers/input/touchscreen/stmfts.c |
| @@ -339,11 +339,11 @@ static int stmfts_input_open(struct input_dev *dev) |
| |
| err = pm_runtime_get_sync(&sdata->client->dev); |
| if (err < 0) |
| - return err; |
| + goto out; |
| |
| err = i2c_smbus_write_byte(sdata->client, STMFTS_MS_MT_SENSE_ON); |
| if (err) |
| - return err; |
| + goto out; |
| |
| mutex_lock(&sdata->mutex); |
| sdata->running = true; |
| @@ -366,7 +366,9 @@ static int stmfts_input_open(struct input_dev *dev) |
| "failed to enable touchkey\n"); |
| } |
| |
| - return 0; |
| +out: |
| + pm_runtime_put_noidle(&sdata->client->dev); |
| + return err; |
| } |
| |
| static void stmfts_input_close(struct input_dev *dev) |
| -- |
| 2.35.1 |
| |