| From 7a2e4fffa2a47f3954bc76a854ce8683dcbc16e4 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 11 May 2022 09:58:56 +0200 |
| Subject: gpio: mvebu/pwm: Refuse requests with inverted polarity |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
| |
| [ Upstream commit 3ecb10175b1f776f076553c24e2689e42953fef5 ] |
| |
| The driver doesn't take struct pwm_state::polarity into account when |
| configuring the hardware, so refuse requests for inverted polarity. |
| |
| Fixes: 757642f9a584 ("gpio: mvebu: Add limited PWM support") |
| Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> |
| Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpio/gpio-mvebu.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| diff --git a/drivers/gpio/gpio-mvebu.c b/drivers/gpio/gpio-mvebu.c |
| index b14d481ab7db..cbad11029c67 100644 |
| --- a/drivers/gpio/gpio-mvebu.c |
| +++ b/drivers/gpio/gpio-mvebu.c |
| @@ -694,6 +694,9 @@ static int mvebu_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm, |
| unsigned long flags; |
| unsigned int on, off; |
| |
| + if (state->polarity != PWM_POLARITY_NORMAL) |
| + return -EINVAL; |
| + |
| val = (unsigned long long) mvpwm->clk_rate * state->duty_cycle; |
| do_div(val, NSEC_PER_SEC); |
| if (val > UINT_MAX) |
| -- |
| 2.35.1 |
| |
