tag ed093944c68b6763013a27c747c0d7193169c0cb
tagger Sumit Semwal <sumit.semwal@linaro.org> Fri Apr 24 17:10:56 2015 +0530
object 72449cb47b0104c32ff8fb9380ade9113375d8d1

- cleanup of dma_buf_export()
- correction of copy-paste stupidity while doing the cleanup

commit 72449cb47b0104c32ff8fb9380ade9113375d8d1
author Sumit Semwal <sumit.semwal@linaro.org> Sat Feb 21 09:00:17 2015 +0530
committer Sumit Semwal <sumit.semwal@linaro.org> Tue Apr 21 14:47:16 2015 +0530
tree f3cf60315d9b4a994e62c86ac4c9db44daaa85a0
parent d8fbe341beb617ebb22b98fb893e4aa32ae2d864

staging: android: ion: fix wrong init of dma_buf_export_info

Fixes: 817bd7253291 ("dma-buf: cleanup dma_buf_export() to make it
easily extensible")

Stupid copy-paste from me in the above patch leads to the following static
checker warning:

        drivers/staging/android/ion/ion.c:1112 ion_share_dma_buf()
        error: potentially dereferencing uninitialized 'buffer'.

drivers/staging/android/ion/ion.c
  1103  struct dma_buf *ion_share_dma_buf(struct ion_client *client,
  1104                                                  struct
ion_handle *handle)
  1105  {
  1106          struct ion_buffer *buffer;
                                   ^^^^^^
  1107          struct dma_buf *dmabuf;
  1108          bool valid_handle;
  1109          DEFINE_DMA_BUF_EXPORT_INFO(exp_info);
  1110
  1111          exp_info.ops = &dma_buf_ops;
  1112          exp_info.size = buffer->size;
                                ^^^^^^
  1113          exp_info.flags = O_RDWR;
  1114          exp_info.priv = buffer;
                                ^^^^^^
And here also.

  1115

This patch corrects this stupidity.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>