- Fix undefined temperature if negative on the rcar_gen3 (Dien Pham)

- Fix wrong frequency converted from power for the cpufreq cooling
  device (Finley Xiao)

- Fix compilation warnings by making functions static in the tsens
  driver (Amit Kucheria)

- Fix return value of sprd_thm_probe for the Spreadtrum driver
  (Tiezhu Yang)

- Fix bank number settings on the Mediatek mt8183 (Michael Kao)

- Fix missing of_node_put() at probe time i.MX (Anson Huang)
-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEGn3N4YVz0WNVyHskqDIjiipP6E8FAl75wVkACgkQqDIjiipP
6E+l4AgAmwNQWwiPk9yErKXzdUVi4O22y7dbtQ4EVgSI9tUdowXyw61IEaGXKrll
/j7mZ1JbReJxznil/hVlIT3YK2CqZuApqSNEOZGZ4YsMu5x6nz5GLLVBDGx1/cX3
k25bcSyhb9oEqjDno/GrpdKXWYd4cmbE4lOmNaOWny3LrpdKCwgazRZ9saRaLCKs
dgk3qqGLkTxMDqHWhkBEQHmDHmDuP1p5G6TqlhkigYDdfmeg84qBLg9GiBfVqGn1
t5z4GoK9jiAm1d8CeduQMDZvxRhGVB30V7qHhpvA7EG0kpe1LtakvQd1GvtYllHy
tigFfUcuJFqCAhEPSW0F923WVZj1dw==
=ilNd
-----END PGP SIGNATURE-----
thermal/drivers/rcar_gen3: Fix undefined temperature if negative

As description for DIV_ROUND_CLOSEST in file include/linux/kernel.h.
  "Result is undefined for negative divisors if the dividend variable
   type is unsigned and for negative dividends if the divisor variable
   type is unsigned."

In current code, the FIXPT_DIV uses DIV_ROUND_CLOSEST but has not
checked sign of divisor before using. It makes undefined temperature
value in case the value is negative.

This patch fixes to satisfy DIV_ROUND_CLOSEST description
and fix bug too. Note that the variable name "reg" is not good
because it should be the same type as rcar_gen3_thermal_read().
However, it's better to rename the "reg" in a further patch as
cleanup.

Signed-off-by: Van Do <van.do.xw@renesas.com>
Signed-off-by: Dien Pham <dien.pham.ry@renesas.com>
[shimoda: minor fixes, add Fixes tag]
Fixes: 564e73d283af ("thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Reviewed-by: Niklas Soderlund <niklas.soderlund+renesas@ragnatech.se>
Tested-by: Niklas Soderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/1593085099-2057-1-git-send-email-yoshihiro.shimoda.uh@renesas.com
1 file changed