)]}'
{
  "commit": "7e1caeace0418381f36b3aa8403dfd82fc57fc53",
  "tree": "d622b154536bda4d7c39fa95f699875140295e42",
  "parents": [
    "7cd5af0e937a197295f3aa3721031f0fbae49cff"
  ],
  "author": {
    "name": "Vlad Buslov",
    "email": "vladbu@nvidia.com",
    "time": "Tue Nov 14 18:59:15 2023 +0100"
  },
  "committer": {
    "name": "Paolo Abeni",
    "email": "pabeni@redhat.com",
    "time": "Thu Nov 16 10:52:59 2023 +0100"
  },
  "message": "macvlan: Don\u0027t propagate promisc change to lower dev in passthru\n\nMacvlan device in passthru mode sets its lower device promiscuous mode\naccording to its MACVLAN_FLAG_NOPROMISC flag instead of synchronizing it to\nits own promiscuity setting. However, macvlan_change_rx_flags() function\ndoesn\u0027t check the mode before propagating such changes to the lower device\nwhich can cause net_device-\u003epromiscuity counter overflow as illustrated by\nreproduction example [0] and resulting dmesg log [1]. Fix the issue by\nfirst verifying the mode in macvlan_change_rx_flags() function before\npropagating promiscuous mode change to the lower device.\n\n[0]:\nip link add macvlan1 link enp8s0f0 type macvlan mode passthru\nip link set macvlan1 promisc on\nip l set dev macvlan1 up\nip link set macvlan1 promisc off\nip l set dev macvlan1 down\nip l set dev macvlan1 up\n\n[1]:\n[ 5156.281724] macvlan1: entered promiscuous mode\n[ 5156.285467] mlx5_core 0000:08:00.0 enp8s0f0: entered promiscuous mode\n[ 5156.287639] macvlan1: left promiscuous mode\n[ 5156.288339] mlx5_core 0000:08:00.0 enp8s0f0: left promiscuous mode\n[ 5156.290907] mlx5_core 0000:08:00.0 enp8s0f0: entered promiscuous mode\n[ 5156.317197] mlx5_core 0000:08:00.0 enp8s0f0: promiscuity touches roof, set promiscuity failed. promiscuity feature of device might be broken.\n\nFixes: efdbd2b30caa (\"macvlan: Propagate promiscuity setting to lower devices.\")\nReviewed-by: Gal Pressman \u003cgal@nvidia.com\u003e\nSigned-off-by: Vlad Buslov \u003cvladbu@nvidia.com\u003e\nReviewed-by: Jiri Pirko \u003cjiri@nvidia.com\u003e\nLink: https://lore.kernel.org/r/20231114175915.1649154-1-vladbu@nvidia.com\nSigned-off-by: Paolo Abeni \u003cpabeni@redhat.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "02bd201bc7e58e566af962986e2c3bf00deba50e",
      "old_mode": 33188,
      "old_path": "drivers/net/macvlan.c",
      "new_id": "c8da94af4161a5fc7e61aae5e11646bc0a5013fd",
      "new_mode": 33188,
      "new_path": "drivers/net/macvlan.c"
    }
  ]
}