trace-cmd: Always initialize write_record() len
write_record() uses an uninitializedd 'len' when record->size is 0. I'm
not sure how likely this case is.
To be safe and silence compiler warning, unconditionally initialize len.
Link: http://lore.kernel.org/linux-trace-devel/20190627152502.174918-1-gthelen@google.com
Fixes: 87d2a344a ("trace-cmd: Add split feature")
Signed-off-by: Greg Thelen <gthelen@google.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
diff --git a/tracecmd/trace-split.c b/tracecmd/trace-split.c
index d27b3c6..6c8a774 100644
--- a/tracecmd/trace-split.c
+++ b/tracecmd/trace-split.c
@@ -80,7 +80,7 @@
unsigned long long diff;
struct tep_handle *pevent;
void *page;
- int len;
+ int len = 0;
char *ptr;
int index = 0;
int time;
@@ -106,12 +106,8 @@
return 0;
}
- if (record->size) {
- if (record->size < 28 * 4)
- len = record->size / 4;
- else
- len = 0;
- }
+ if (record->size && (record->size < 28 * 4))
+ len = record->size / 4;
time = (unsigned)diff;
time = create_type_len(pevent, time, len);
