Google Git
Sign in
kernel / pub / scm / network / ethtool / ethtool / ecdf2952521c8e37bb608bb61384be95bceb68cd
commitecdf2952521c8e37bb608bb61384be95bceb68cd[log] [tgz]
authorEran Ben Elisha <eranbe@mellanox.com>Tue Oct 02 10:24:19 2018 +0300
committerJohn W. Linville <linville@tuxdriver.com>Thu Oct 04 15:02:21 2018 -0400
tree67f0321651b8493af4bb0ffa9c7a2f83f9e64239
parent98c148e8651b01561a8fb1ad8201c1d4a6c30d64 [diff]
ethtool: Fix uninitialized variable use at qsfp dump

Struct sff_diags can be used uninitialized at sff8636_show_dom, this
caused the tool to show unreported fields (supports_alarms) by the lower
level driver.

In addition, make sure the same struct is being initialized at
sff8472_parse_eeprom function, to avoid the same issue here.

Fixes: a5e73bb05ee4 ("ethtool:QSFP Plus/QSFP28 Diagnostics Information Support")
Signed-off-by: Eran Ben Elisha <eranbe@mellanox.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
2 files changed
tree: 67f0321651b8493af4bb0ffa9c7a2f83f9e64239
  1. .gitignore
  2. amd8111e.c
  3. at76c50x-usb.c
  4. AUTHORS
  5. autogen.sh
  6. ChangeLog
  7. configure.ac
  8. COPYING
  9. de2104x.c
  10. e100.c
  11. e1000.c
  12. et131x.c
  13. ethtool-copy.h
  14. ethtool.8.in
  15. ethtool.c
  16. ethtool.spec.in
  17. fec_8xx.c
  18. fjes.c
  19. ibm_emac.c
  20. igb.c
  21. internal.h
  22. ixgb.c
  23. ixgbe.c
  24. ixgbevf.c
  25. lan78xx.c
  26. LICENSE
  27. Makefile.am
  28. marvell.c
  29. natsemi.c
  30. net_tstamp-copy.h
  31. NEWS
  32. pcnet32.c
  33. qsfp.c
  34. qsfp.h
  35. README
  36. realtek.c
  37. rxclass.c
  38. sfc.c
  39. sff-common.c
  40. sff-common.h
  41. sfpdiag.c
  42. sfpid.c
  43. smsc911x.c
  44. stmmac.c
  45. test-cmdline.c
  46. test-common.c
  47. test-features.c
  48. tg3.c
  49. tse.c
  50. vioc.c
  51. vmxnet3.c