ndctl. test: fix module-taint sanity-check

Commit 625f5bc23826 upstream.

nfit_test_init() validates that the libnvdimm modules that a test would
use are the properly instrumented external versions. If module signing
is enabled the sanity check will fail because the check expects only the
'O' flag, but unsigned external modules will have the 'O' flag and the
'E' flag set. Relax the constraint to just check for 'O'.

Fixes: 00fc65075c89 ("test: validate nfit_test modules...")
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
1 file changed
tree: 63ed14e7ebd9a824f9c10d01b6448ee31e0cbd49
  1. .gitignore
  3. Documentation/
  4. Makefile.am
  5. Makefile.am.in
  6. README.md
  7. autogen.sh
  8. builtin.h
  9. ccan/
  10. configure.ac
  11. contrib/
  12. daxctl/
  13. git-version
  14. git-version-gen
  15. licenses/
  16. m4/
  17. make-git-snapshot.sh
  18. ndctl.spec.in
  19. ndctl/
  20. nfit.h
  21. rpmbuild.sh
  22. sles/
  23. test.h
  24. test/
  25. util/


Utility library for managing the libnvdimm (non-volatile memory device) sub-system in the Linux kernel


./configure CFLAGS='-g -O0' --prefix=/usr --sysconfdir=/etc --libdir=/usr/lib64
make check
sudo make install

There are a number of packages required for the build steps that may not be installed by default. For information about the required packages, see the “BuildRequires:” lines in ndctl.spec.in.



See the latest documentation for the NVDIMM kernel sub-system here:


Unit Tests

The unit tests run by make check require the nfit_test.ko module to be loaded. To build and install nfit_test.ko:

  1. Obtain the kernel source. For example,
    git clone -b libnvdimm-for-next git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git

  2. Skip to step 3 if the kernel version is >= v4.8. Otherwise, for kernel versions < v4.8, configure the kernel to make some memory available to CMA (contiguous memory allocator). This will be used to emulate DAX.
    cma=200M on the kernel command line.

  3. Compile the libnvdimm sub-system as a module, make sure “zone device” memory is enabled, and enable the btt, pfn, and dax features of the sub-system:

  4. Build and install the unit test enabled libnvdimm modules in the following order. The unit test modules need to be in place prior to the depmod that runs during the final modules_install
    make M=tools/testing/nvdimm
    sudo make M=tools/testing/nvdimm modules_install
    sudo make modules_install

  5. Now run make check in the ndctl source directory, or ndctl test, if ndctl was built with --enable-test.


The unit tests will validate that the environment is set up correctly before they try to run. If the platform is misconfigured, i.e. the unit test modules are not available, or the test versions of the modules are superseded by the “in-tree/production” version of the modules make check will skip tests and report a message like the following in test/test-suite.log:
SKIP: libndctl
test/init: nfit_test_init: nfit.ko: appears to be production version: /lib/modules/4.8.8-200.fc24.x86_64/kernel/drivers/acpi/nfit/nfit.ko.xz
__ndctl_test_skip: explicit skip test_libndctl:2684
nfit_test unavailable skipping tests

If the unit test modules are indeed available in the modules ‘extra’ directory the default depmod policy can be overridden by adding a file to /etc/depmod.d with the following contents:
override nfit * extra
override device_dax * extra override dax_pmem * extra
override libnvdimm * extra
override nd_blk * extra
override nd_btt * extra
override nd_e820 * extra
override nd_pmem * extra

The nfit_test module emulates pmem with memory allocated via vmalloc(). One of the side effects is that this breaks ‘physically contiguous’ assumptions in the driver. Use the '--align=4K option to ‘ndctl create-namespace’ to avoid these corner case scenarios.