Thank you for taking the time to contribute to ndctl.
The following is a set of guidelines that we adhere to, and request that contributors follow.
The libnvdimm (kernel subsystem) and ndctl developers primarily use the linux-nvdimm mailing list for everything. It is recommended to send patches to
We follow the Linux Kernel Coding Style Guide as applicable.
We follow the Linux Kernel Submitting Patches Guide as applicable.
We follow the Linux Kernel DCO (Developer Certificate of Origin). The DCO is an attestation attached to every contribution made by every developer. In the commit message of the contribution, the developer simply adds a Signed-off-by statement and thereby agrees to the DCO.
Github Pull Requests are acceptable mainly for smaller, more obvious fixups, but won‘t be merged directly, as Github doesn’t allow for the kernel style flow of patches where a maintainer also signs off on the patches they apply. Larger changes may need to be sent to the mailing list so that everyone gets an opportunity to review them.
Misc Best Practices:
Use a subject prefix of “ndctl PATCH” (or “ndctl PATCH vN” for a new revision). This can be automated for a
git format-patch command by setting a repo-local git config setting:
git config format.subjectprefix "ndctl PATCH"
For commit messages: Describe the change and why it was needed. Use a concise subject line, and a blank line between the subject and the body, as well as between paragraphs. Use present tense and the imperative mood (e.g. “Add support for..” instead of “Added support..” or “Adding support”). Word-wrap to 72 columns.