commit | 0eac5394af6b481328857d43acb5d8e628b0dbac | [log] [tgz] |
---|---|---|
author | Evgeny Yakovlev <wrfsh@yandex-team.ru> | Tue Mar 05 11:03:39 2019 +0300 |
committer | Paolo Bonzini <pbonzini@redhat.com> | Fri Mar 08 14:03:30 2019 +0100 |
tree | 098e3339c5ee4c8a8c04ed76fd301a786317b358 | |
parent | 6485ecdd977d786eb5c5cf0fee17ad5a85d32630 [diff] |
x86/apic: wait for wrap around in lapic timer periodic test We are seeing very rare test failures in apic/split-apic with the following: "FAIL: TMCCT should be reset to the initial-count". We are running on 4.14 kernels and this problem occurs sporadically although we didn't try to reproduce it on any other stable kernel branch. It looks like under KVM lapic timer in periodic mode may return several consecutive 0 values in apic_get_tmccr when hrtimer async callback is still restarting the hrtimer and recalculating expiration_time value but apic_get_tmccr is seeing ktime_now() already ahead of (still old) expiration_time value. After a couple of 0-es from TMCCR everything goes back to normal. This change forces test_apic_change_mode test to wait specifically for lapic timer wrap around skipping zero TMCCR values in one case when we are testing for timer in periodic mode to correctly reload TMCCR from TMICR. If timer mode change is indeed broken and TMCCR is not reset then we will see apic test timeout. Signed-off-by: Evgeny Yakovlev <wrfsh@yandex-team.ru> Message-Id: <1551773019-19121-1-git-send-email-wrfsh@yandex-team.ru> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
See http://www.linux-kvm.org/page/KVM-unit-tests for a high-level description of this project, as well as running tests and adding tests HOWTOs.
This directory contains sources for a kvm test suite.
To create the test images do:
./configure make
in this directory. Test images are created in .//*.flat
The tests can be built as standalone To create and use standalone tests do:
./configure make standalone (send tests/some-test somewhere) (go to somewhere) ./some-test
‘make install’ will install all tests in PREFIX/share/kvm-unit-tests/tests, each as a standalone test.
Then use the runner script to detect the correct invocation and invoke the test:
./x86-run ./x86/msr.flat
or:
./run_tests.sh
to run them all.
To select a specific qemu binary, specify the QEMU= environment variable:
QEMU=/tmp/qemu/x86_64-softmmu/qemu-system-x86_64 ./x86-run ./x86/msr.flat
To select an accelerator, for example “kvm” or “tcg”, specify the ACCEL= environment variable:
ACCEL=kvm ./x86-run ./x86/msr.flat
Unit tests use QEMU's ‘-append <args...>’ parameter for command line inputs, i.e. all args will be available as argv strings in main(). Additionally a file of the form
KEY=VAL KEY2=VAL ...
may be passed with ‘-initrd ’ to become the unit test's environ, which can then be accessed in the usual ways, e.g. VAL = getenv(“KEY”) Any key=val strings can be passed, but some have reserved meanings in the framework. The list of reserved environment variables is below
QEMU_ACCEL ... either kvm or tcg QEMU_VERSION_STRING ... string of the form qemu -h | head -1
KERNEL_VERSION_STRING ... string of the form uname -r
Additionally these self-explanatory variables are reserved
QEMU_MAJOR, QEMU_MINOR, QEMU_MICRO, KERNEL_VERSION, KERNEL_PATCHLEVEL, KERNEL_SUBLEVEL, KERNEL_EXTRAVERSION
Some tests are not safe to run by default, as they may crash the host. kvm-unit-tests provides two ways to handle tests like those.
Adding ‘nodefault’ to the groups field for the unit test in the unittests.cfg file. When a unit test is in the nodefault group it is only run when invoked
a) independently, arch-run arch/test b) by specifying any other non-nodefault group it is in, groups = nodefault,mygroup : ./run_tests.sh -g mygroup c) by specifying all tests should be run, ./run_tests.sh -a
Making the test conditional on errata in the code, if (ERRATA(abcdef012345)) { do_unsafe_test(); }
With the errata condition the unsafe unit test is only run when
a) the ERRATA_abcdef012345 environ variable is provided and ‘y’ b) the ERRATA_FORCE environ variable is provided and ‘y’ c) by specifying all tests should be run, ./run_tests.sh -a (The -a switch ensures the ERRATA_FORCE is provided and set to ‘y’.)
The errata.txt file provides a mapping of the commits needed by errata conditionals to their respective minimum kernel versions. By default, when the user does not provide an environ, then an environ generated from the errata.txt file and the host's kernel version is provided to all unit tests.
.: configure script, top-level Makefile, and run_tests.sh ./scripts: helper scripts for building and running tests ./lib: general architecture neutral services for the tests ./lib/<ARCH>: architecture dependent services for the tests ./<ARCH>: the sources of the tests and the created objects/images
See /README for architecture specific documentation.
Currently there is a mix of indentation styles so any changes to existing files should be consistent with the existing style. For new files:
Exceptions:
Patches are welcome at the KVM mailing list kvm@vger.kernel.org.
Please prefix messages with: [kvm-unit-tests PATCH]
You can add the following to .git/config to do this automatically for you:
[format] subjectprefix = kvm-unit-tests PATCH
Additionally it‘s helpful to have a common order of file types in patches. Our chosen order attempts to place the more declarative files before the code files. We also start with common code and finish with unit test code. git-diff’s orderFile feature allows us to specify the order in a file. The orderFile we use is scripts/git.difforder
. Adding the config with git config diff.orderFile scripts/git.difforder
enables it.