| From: Johan Hovold <johan@kernel.org> |
| Date: Tue, 1 Nov 2016 11:40:25 +0100 |
| Subject: USB: phy: am335x-control: fix device and of_node leaks |
| |
| commit 015105b12183556771e111e93f5266851e7c5582 upstream. |
| |
| Make sure to drop the references taken by of_parse_phandle() and |
| bus_find_device() before returning from am335x_get_phy_control(). |
| |
| Note that there is no guarantee that the devres-managed struct |
| phy_control will be valid for the lifetime of the sibling phy device |
| regardless of this change. |
| |
| Fixes: 3bb869c8b3f1 ("usb: phy: Add AM335x PHY driver") |
| Acked-by: Bin Liu <b-liu@ti.com> |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com> |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| --- |
| drivers/usb/phy/phy-am335x-control.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- a/drivers/usb/phy/phy-am335x-control.c |
| +++ b/drivers/usb/phy/phy-am335x-control.c |
| @@ -126,10 +126,12 @@ struct phy_control *am335x_get_phy_contr |
| return NULL; |
| |
| dev = bus_find_device(&platform_bus_type, NULL, node, match); |
| + of_node_put(node); |
| if (!dev) |
| return NULL; |
| |
| ctrl_usb = dev_get_drvdata(dev); |
| + put_device(dev); |
| if (!ctrl_usb) |
| return NULL; |
| return &ctrl_usb->phy_ctrl; |
