| From d9ebaa45472c92704f4814682eec21455edcfa1f Mon Sep 17 00:00:00 2001 |
| From: Hans de Goede <hdegoede@redhat.com> |
| Date: Sun, 13 Mar 2011 13:50:33 +0100 |
| Subject: hwmon/f71882fg: Set platform drvdata to NULL later |
| |
| From: Hans de Goede <hdegoede@redhat.com> |
| |
| commit d9ebaa45472c92704f4814682eec21455edcfa1f upstream. |
| |
| This avoids a possible race leading to trying to dereference NULL. |
| |
| Signed-off-by: Hans de Goede <hdegoede@redhat.com> |
| Acked-by: Jean Delvare <khali@linux-fr.org> |
| Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| drivers/hwmon/f71882fg.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/hwmon/f71882fg.c |
| +++ b/drivers/hwmon/f71882fg.c |
| @@ -1957,7 +1957,6 @@ static int f71882fg_remove(struct platfo |
| int i; |
| struct f71882fg_data *data = platform_get_drvdata(pdev); |
| |
| - platform_set_drvdata(pdev, NULL); |
| if (data->hwmon_dev) |
| hwmon_device_unregister(data->hwmon_dev); |
| |
| @@ -1982,6 +1981,7 @@ static int f71882fg_remove(struct platfo |
| for (i = 0; i < ARRAY_SIZE(f8000_fan_attr); i++) |
| device_remove_file(&pdev->dev, &f8000_fan_attr[i].dev_attr); |
| |
| + platform_set_drvdata(pdev, NULL); |
| kfree(data); |
| |
| return 0; |