| From 2e0298a1786d88ad0cecab167666d2e220ed0499 Mon Sep 17 00:00:00 2001 |
| From: Sebastian Andrzej Siewior <bigeasy@linutronix.de> |
| Date: Mon, 12 Aug 2013 16:11:51 +0200 |
| Subject: [PATCH] powerpc: 52xx: provide a default in mpc52xx_irqhost_map() |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| My gcc-4.3.5 fails to compile due to: |
| |
| |cc1: warnings being treated as errors |
| |arch/powerpc/platforms/52xx/mpc52xx_pic.c: In function ‘mpc52xx_irqhost_map’: |
| |arch/powerpc/platforms/52xx/mpc52xx_pic.c:343: error: ‘irqchip’ may be used uninitialized in this function |
| |
| since commit e34298c ("powerpc: 52xx: nop out unsupported critical |
| IRQs"). This warning is complete crap since only values 0…3 are possible |
| which are checked but gcc fails to understand that. I wouldn't care much |
| but since this is compiled with -Werror I made this patch. |
| While add it, I replaced the warning from l2irq to l1irq since this is |
| the number that is evaluated. |
| |
| Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> |
| --- |
| arch/powerpc/platforms/52xx/mpc52xx_pic.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/arch/powerpc/platforms/52xx/mpc52xx_pic.c b/arch/powerpc/platforms/52xx/mpc52xx_pic.c |
| index b89ef65..b69221b 100644 |
| --- a/arch/powerpc/platforms/52xx/mpc52xx_pic.c |
| +++ b/arch/powerpc/platforms/52xx/mpc52xx_pic.c |
| @@ -373,8 +373,9 @@ static int mpc52xx_irqhost_map(struct irq_domain *h, unsigned int virq, |
| case MPC52xx_IRQ_L1_PERP: irqchip = &mpc52xx_periph_irqchip; break; |
| case MPC52xx_IRQ_L1_SDMA: irqchip = &mpc52xx_sdma_irqchip; break; |
| case MPC52xx_IRQ_L1_CRIT: |
| + default: |
| pr_warn("%s: Critical IRQ #%d is unsupported! Nopping it.\n", |
| - __func__, l2irq); |
| + __func__, l1irq); |
| irq_set_chip(virq, &no_irq_chip); |
| return 0; |
| } |
| -- |
| 1.8.4.rc1 |
| |
