| From 35652e9ce4e36609bda2397669738535aefb5b90 Mon Sep 17 00:00:00 2001 |
| From: Hans de Goede <hdegoede@redhat.com> |
| Date: Sun, 13 Mar 2011 13:50:33 +0100 |
| Subject: [PATCH] hwmon/f71882fg: Set platform drvdata to NULL later |
| |
| commit d9ebaa45472c92704f4814682eec21455edcfa1f upstream. |
| |
| This avoids a possible race leading to trying to dereference NULL. |
| |
| Signed-off-by: Hans de Goede <hdegoede@redhat.com> |
| Acked-by: Jean Delvare <khali@linux-fr.org> |
| Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/hwmon/f71882fg.c b/drivers/hwmon/f71882fg.c |
| index a95fa42..03f08b2 100644 |
| --- a/drivers/hwmon/f71882fg.c |
| +++ b/drivers/hwmon/f71882fg.c |
| @@ -2031,7 +2031,6 @@ static int f71882fg_remove(struct platform_device *pdev) |
| int nr_fans = (data->type == f71882fg) ? 4 : 3; |
| u8 start_reg = f71882fg_read8(data, F71882FG_REG_START); |
| |
| - platform_set_drvdata(pdev, NULL); |
| if (data->hwmon_dev) |
| hwmon_device_unregister(data->hwmon_dev); |
| |
| @@ -2098,6 +2097,7 @@ static int f71882fg_remove(struct platform_device *pdev) |
| } |
| } |
| |
| + platform_set_drvdata(pdev, NULL); |
| kfree(data); |
| |
| return 0; |
| -- |
| 1.7.4.4 |
| |
