| From 8e3f9e2a3e96e8e025aef02bf3c2df81e7506d99 Mon Sep 17 00:00:00 2001 |
| From: Johan Hovold <jhovold@gmail.com> |
| Date: Thu, 25 Oct 2012 13:35:10 +0200 |
| Subject: [PATCH] USB: mos7840: fix port-device leak in error path |
| |
| commit 3eb55cc4ed88eee3b5230f66abcdbd2a91639eda upstream. |
| |
| The driver set the usb-serial port pointers to NULL on errors in attach, |
| effectively preventing usb-serial core from decrementing the port ref |
| counters and releasing the port devices and associated data. |
| |
| Signed-off-by: Johan Hovold <jhovold@gmail.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| --- |
| drivers/usb/serial/mos7840.c | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c |
| index d891d44501f8..c55d2aa35eaa 100644 |
| --- a/drivers/usb/serial/mos7840.c |
| +++ b/drivers/usb/serial/mos7840.c |
| @@ -2565,7 +2565,6 @@ error: |
| kfree(mos7840_port->ctrl_buf); |
| usb_free_urb(mos7840_port->control_urb); |
| kfree(mos7840_port); |
| - serial->port[i] = NULL; |
| } |
| return status; |
| } |
| -- |
| 1.8.5.2 |
| |
