| From 043815bbfa2a49eee8d7f020cbeeac72fbb977a9 Mon Sep 17 00:00:00 2001 |
| From: Mathias Krause <minipli@googlemail.com> |
| Date: Wed, 15 Aug 2012 11:31:45 +0000 |
| Subject: [PATCH] atm: fix info leak via getsockname() |
| |
| commit 3c0c5cfdcd4d69ffc4b9c0907cec99039f30a50a upstream. |
| |
| The ATM code fails to initialize the two padding bytes of struct |
| sockaddr_atmpvc inserted for alignment. Add an explicit memset(0) |
| before filling the structure to avoid the info leak. |
| |
| Signed-off-by: Mathias Krause <minipli@googlemail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| --- |
| net/atm/pvc.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/net/atm/pvc.c b/net/atm/pvc.c |
| index 437ee70c5e62..db0dd47de61b 100644 |
| --- a/net/atm/pvc.c |
| +++ b/net/atm/pvc.c |
| @@ -94,6 +94,7 @@ static int pvc_getname(struct socket *sock, struct sockaddr *sockaddr, |
| return -ENOTCONN; |
| *sockaddr_len = sizeof(struct sockaddr_atmpvc); |
| addr = (struct sockaddr_atmpvc *)sockaddr; |
| + memset(addr, 0, sizeof(*addr)); |
| addr->sap_family = AF_ATMPVC; |
| addr->sap_addr.itf = vcc->dev->number; |
| addr->sap_addr.vpi = vcc->vpi; |
| -- |
| 1.8.5.2 |
| |
