| From a11718032a4b529374c20b06a5ad58bf99093294 Mon Sep 17 00:00:00 2001 |
| From: Guenter Roeck <linux@roeck-us.net> |
| Date: Sun, 20 Nov 2016 10:37:39 -0800 |
| Subject: [PATCH] hwmon: (ds620) Fix overflows seen when writing temperature |
| limits |
| |
| commit e36ce99ee0815d7919a7b589bfb66f3de50b6bc7 upstream. |
| |
| Module test reports: |
| |
| temp1_max: Suspected overflow: [160000 vs. 0] |
| temp1_min: Suspected overflow: [160000 vs. 0] |
| |
| This is seen because the values passed when writing temperature limits |
| are unbound. |
| |
| Reviewed-by: Jean Delvare <jdelvare@suse.de> |
| Fixes: 6099469805c2 ("hwmon: Support for Dallas Semiconductor DS620") |
| Signed-off-by: Guenter Roeck <linux@roeck-us.net> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/hwmon/ds620.c b/drivers/hwmon/ds620.c |
| index edf550fc4eef..0043a4c02b85 100644 |
| --- a/drivers/hwmon/ds620.c |
| +++ b/drivers/hwmon/ds620.c |
| @@ -166,7 +166,7 @@ static ssize_t set_temp(struct device *dev, struct device_attribute *da, |
| if (res) |
| return res; |
| |
| - val = (val * 10 / 625) * 8; |
| + val = (clamp_val(val, -128000, 128000) * 10 / 625) * 8; |
| |
| mutex_lock(&data->update_lock); |
| data->temp[attr->index] = val; |
| -- |
| 2.10.1 |
| |
