| From 4701411f8e40d5e3250a6f937dd57524a333542f Mon Sep 17 00:00:00 2001 |
| From: Johan Hovold <johan@kernel.org> |
| Date: Tue, 3 Jan 2017 16:39:41 +0100 |
| Subject: [PATCH] USB: serial: garmin_gps: fix memory leak on failed URB submit |
| |
| commit c4ac4496e835b78a45dfbf74f6173932217e4116 upstream. |
| |
| Make sure to free the URB transfer buffer in case submission fails (e.g. |
| due to a disconnect). |
| |
| Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") |
| Cc: stable <stable@vger.kernel.org> |
| Signed-off-by: Johan Hovold <johan@kernel.org> |
| Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> |
| |
| diff --git a/drivers/usb/serial/garmin_gps.c b/drivers/usb/serial/garmin_gps.c |
| index 97cabf803c2f..b2f2e87aed94 100644 |
| --- a/drivers/usb/serial/garmin_gps.c |
| +++ b/drivers/usb/serial/garmin_gps.c |
| @@ -1043,6 +1043,7 @@ static int garmin_write_bulk(struct usb_serial_port *port, |
| "%s - usb_submit_urb(write bulk) failed with status = %d\n", |
| __func__, status); |
| count = status; |
| + kfree(buffer); |
| } |
| |
| /* we are done with this urb, so let the host driver |
| -- |
| 2.10.1 |
| |
