| From: Jiri Slaby <jslaby@suse.cz> |
| Subject: dca: check against empty dca_domains list before unregister provider fix |
| |
| In 3.0.67, commit 7a9a20ea77e7508c795dead9ab2f6c98a617762d (dca: check |
| against empty dca_domains list before unregister provider), upstream |
| commit c419fcfd071cf34ba00f9f65282583772d2655e7, added a fail path to |
| unregister_dca_provider. It added there also a call to |
| raw_spin_unlock_irqrestore. But in 3.0, the lock is not raw, so this |
| results in: |
| drivers/dca/dca-core.c: In function 'unregister_dca_provider': |
| drivers/dca/dca-core.c:413: warning: passing argument 1 of '_raw_spin_unlock_irqrestore' from incompatible pointer type |
| |
| Fix it by calling spin_unlock_irqrestore properly. |
| |
| Signed-off-by: Jiri Slaby <jslaby@suse.cz> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/dca/dca-core.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/dca/dca-core.c |
| +++ b/drivers/dca/dca-core.c |
| @@ -410,7 +410,7 @@ void unregister_dca_provider(struct dca_ |
| spin_lock_irqsave(&dca_lock, flags); |
| |
| if (list_empty(&dca_domains)) { |
| - raw_spin_unlock_irqrestore(&dca_lock, flags); |
| + spin_unlock_irqrestore(&dca_lock, flags); |
| return; |
| } |
| |