| From 5d60122b7e30f275593df93b39a76d3c2663cfc2 Mon Sep 17 00:00:00 2001 |
| From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali.rohar@gmail.com> |
| Date: Tue, 22 Apr 2014 12:02:39 -0300 |
| Subject: media: radio-bcm2048: fix wrong overflow check |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: =?UTF-8?q?Pali=20Roh=C3=A1r?= <pali.rohar@gmail.com> |
| |
| commit 5d60122b7e30f275593df93b39a76d3c2663cfc2 upstream. |
| |
| This patch fixes an off by one check in bcm2048_set_region(). |
| |
| Reported-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Pali Rohรกr <pali.rohar@gmail.com> |
| Signed-off-by: Pavel Machek <pavel@ucw.cz> |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> |
| Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/staging/media/bcm2048/radio-bcm2048.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/staging/media/bcm2048/radio-bcm2048.c |
| +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c |
| @@ -737,7 +737,7 @@ static int bcm2048_set_region(struct bcm |
| int err; |
| u32 new_frequency = 0; |
| |
| - if (region > ARRAY_SIZE(region_configs)) |
| + if (region >= ARRAY_SIZE(region_configs)) |
| return -EINVAL; |
| |
| mutex_lock(&bdev->mutex); |