| From foo@baz Sat Apr 16 22:36:37 PDT 2016 |
| From: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> |
| Date: Fri, 1 Apr 2016 17:17:50 -0300 |
| Subject: ip6_tunnel: set rtnl_link_ops before calling register_netdevice |
| Status: RO |
| Content-Length: 1146 |
| Lines: 37 |
| |
| From: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> |
| |
| [ Upstream commit b6ee376cb0b7fb4e7e07d6cd248bd40436fb9ba6 ] |
| |
| When creating an ip6tnl tunnel with ip tunnel, rtnl_link_ops is not set |
| before ip6_tnl_create2 is called. When register_netdevice is called, there |
| is no linkinfo attribute in the NEWLINK message because of that. |
| |
| Setting rtnl_link_ops before calling register_netdevice fixes that. |
| |
| Fixes: 0b112457229d ("ip6tnl: add support of link creation via rtnl") |
| Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@redhat.com> |
| Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/ipv6/ip6_tunnel.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/net/ipv6/ip6_tunnel.c |
| +++ b/net/ipv6/ip6_tunnel.c |
| @@ -273,12 +273,12 @@ static int ip6_tnl_create2(struct net_de |
| |
| t = netdev_priv(dev); |
| |
| + dev->rtnl_link_ops = &ip6_link_ops; |
| err = register_netdevice(dev); |
| if (err < 0) |
| goto out; |
| |
| strcpy(t->parms.name, dev->name); |
| - dev->rtnl_link_ops = &ip6_link_ops; |
| |
| dev_hold(dev); |
| ip6_tnl_link(ip6n, t); |
