| From foo@baz Sat Apr 16 22:36:37 PDT 2016 |
| From: Xin Long <lucien.xin@gmail.com> |
| Date: Sun, 28 Feb 2016 10:03:51 +0800 |
| Subject: sctp: lack the check for ports in sctp_v6_cmp_addr |
| Status: RO |
| Content-Length: 1078 |
| Lines: 34 |
| |
| From: Xin Long <lucien.xin@gmail.com> |
| |
| [ Upstream commit 40b4f0fd74e46c017814618d67ec9127ff20f157 ] |
| |
| As the member .cmp_addr of sctp_af_inet6, sctp_v6_cmp_addr should also check |
| the port of addresses, just like sctp_v4_cmp_addr, cause it's invoked by |
| sctp_cmp_addr_exact(). |
| |
| Now sctp_v6_cmp_addr just check the port when two addresses have different |
| family, and lack the port check for two ipv6 addresses. that will make |
| sctp_hash_cmp() cannot work well. |
| |
| so fix it by adding ports comparison in sctp_v6_cmp_addr(). |
| |
| Signed-off-by: Xin Long <lucien.xin@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| net/sctp/ipv6.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- a/net/sctp/ipv6.c |
| +++ b/net/sctp/ipv6.c |
| @@ -519,6 +519,8 @@ static int sctp_v6_cmp_addr(const union |
| } |
| return 0; |
| } |
| + if (addr1->v6.sin6_port != addr2->v6.sin6_port) |
| + return 0; |
| if (!ipv6_addr_equal(&addr1->v6.sin6_addr, &addr2->v6.sin6_addr)) |
| return 0; |
| /* If this is a linklocal address, compare the scope_id. */ |