| From 43508be512661c905d0320ee73e0b65ef36d2459 Mon Sep 17 00:00:00 2001 |
| From: Hans de Goede <hdegoede@redhat.com> |
| Date: Fri, 25 Jul 2014 22:01:27 +0200 |
| Subject: uas: Log a warning when we cannot use uas because the hcd lacks streams |
| |
| From: Hans de Goede <hdegoede@redhat.com> |
| |
| commit 43508be512661c905d0320ee73e0b65ef36d2459 upstream. |
| |
| So that an user who wants to use uas can see why he is not getting uas. |
| |
| Also move the check down so that we don't warn if there are other reasons |
| why uas cannot work. |
| |
| Signed-off-by: Hans de Goede <hdegoede@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/usb/storage/uas-detect.h | 12 +++++++++--- |
| 1 file changed, 9 insertions(+), 3 deletions(-) |
| |
| --- a/drivers/usb/storage/uas-detect.h |
| +++ b/drivers/usb/storage/uas-detect.h |
| @@ -64,9 +64,6 @@ static int uas_use_uas_driver(struct usb |
| if (flags & US_FL_IGNORE_UAS) |
| return 0; |
| |
| - if (udev->speed >= USB_SPEED_SUPER && !hcd->can_do_streams) |
| - return 0; |
| - |
| alt = uas_find_uas_alt_setting(intf); |
| if (alt < 0) |
| return 0; |
| @@ -84,5 +81,14 @@ static int uas_use_uas_driver(struct usb |
| return 0; |
| } |
| |
| + if (udev->speed >= USB_SPEED_SUPER && !hcd->can_do_streams) { |
| + dev_warn(&udev->dev, |
| + "USB controller %s does not support streams, which are required by the UAS driver.\n", |
| + hcd_to_bus(hcd)->bus_name); |
| + dev_warn(&udev->dev, |
| + "Please try an other USB controller if you wish to use UAS.\n"); |
| + return 0; |
| + } |
| + |
| return 1; |
| } |
