| From 4b961180ef275035b1538317ffd0e21e80e63e77 Mon Sep 17 00:00:00 2001 |
| From: Ben Hutchings <ben@decadent.org.uk> |
| Date: Sun, 19 Aug 2012 19:32:27 -0300 |
| Subject: media: rc: ite-cir: Initialise ite_dev::rdev earlier |
| |
| From: Ben Hutchings <ben@decadent.org.uk> |
| |
| commit 4b961180ef275035b1538317ffd0e21e80e63e77 upstream. |
| |
| ite_dev::rdev is currently initialised in ite_probe() after |
| rc_register_device() returns. If a newly registered device is opened |
| quickly enough, we may enable interrupts and try to use ite_dev::rdev |
| before it has been initialised. Move it up to the earliest point we |
| can, right after calling rc_allocate_device(). |
| |
| Reported-and-tested-by: YunQiang Su <wzssyqa@gmail.com> |
| |
| Signed-off-by: Ben Hutchings <ben@decadent.org.uk> |
| Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/media/rc/ite-cir.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/media/rc/ite-cir.c |
| +++ b/drivers/media/rc/ite-cir.c |
| @@ -1473,6 +1473,7 @@ static int ite_probe(struct pnp_dev *pde |
| rdev = rc_allocate_device(); |
| if (!rdev) |
| goto failure; |
| + itdev->rdev = rdev; |
| |
| ret = -ENODEV; |
| |
| @@ -1604,7 +1605,6 @@ static int ite_probe(struct pnp_dev *pde |
| if (ret) |
| goto failure3; |
| |
| - itdev->rdev = rdev; |
| ite_pr(KERN_NOTICE, "driver has been successfully loaded\n"); |
| |
| return 0; |
