| From 474555434b7b6d8af925a7b3f757d67868ac523a Mon Sep 17 00:00:00 2001 |
| From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> |
| Date: Sat, 13 Apr 2013 06:18:56 +0000 |
| Subject: net: mvmdio: add select PHYLIB |
| |
| |
| From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> |
| |
| [ Upstream commit 2e0cbf2cc2c9371f0aa198857d799175ffe231a6 ] |
| |
| The mvmdio driver uses the phylib API, so it should select the PHYLIB |
| symbol, otherwise, a build with mvmdio (but without mvneta) fails to |
| build with undefined symbols such as mdiobus_unregister, mdiobus_free, |
| etc. |
| |
| The mvneta driver does not use the phylib API directly, so it does not |
| need to select PHYLIB. It already selects the mvmdio driver anyway. |
| |
| Historically, this problem is due to the fact that the PHY handling |
| was originally part of mvneta, and was later moved to a separate |
| driver, without updating the Kconfig select statements |
| accordingly. And since there was no functional reason to use mvmdio |
| without mvneta, this case was not tested. |
| |
| Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> |
| Reported-by: Fengguang Wu <fengguang.wu@intel.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/marvell/Kconfig | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/net/ethernet/marvell/Kconfig |
| +++ b/drivers/net/ethernet/marvell/Kconfig |
| @@ -33,6 +33,7 @@ config MV643XX_ETH |
| |
| config MVMDIO |
| tristate "Marvell MDIO interface support" |
| + select PHYLIB |
| ---help--- |
| This driver supports the MDIO interface found in the network |
| interface units of the Marvell EBU SoCs (Kirkwood, Orion5x, |
| @@ -45,7 +46,6 @@ config MVMDIO |
| config MVNETA |
| tristate "Marvell Armada 370/XP network interface support" |
| depends on MACH_ARMADA_370_XP |
| - select PHYLIB |
| select MVMDIO |
| ---help--- |
| This driver supports the network interface units in the |
