| From 8eef7d70f7c6772c3490f410ee2bceab3b543fa1 Mon Sep 17 00:00:00 2001 |
| From: Brian Norris <computersforpeace@gmail.com> |
| Date: Sat, 28 Feb 2015 02:23:25 -0800 |
| Subject: UBI: account for bitflips in both the VID header and data |
| |
| From: Brian Norris <computersforpeace@gmail.com> |
| |
| commit 8eef7d70f7c6772c3490f410ee2bceab3b543fa1 upstream. |
| |
| We are completely discarding the earlier value of 'bitflips', which |
| could reflect a bitflip found in ubi_io_read_vid_hdr(). Let's use the |
| bitwise OR of header and data 'bitflip' statuses instead. |
| |
| Coverity CID #1226856 |
| |
| Signed-off-by: Brian Norris <computersforpeace@gmail.com> |
| Signed-off-by: Richard Weinberger <richard@nod.at> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/mtd/ubi/attach.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/mtd/ubi/attach.c |
| +++ b/drivers/mtd/ubi/attach.c |
| @@ -410,7 +410,7 @@ int ubi_compare_lebs(struct ubi_device * |
| second_is_newer = !second_is_newer; |
| } else { |
| dbg_bld("PEB %d CRC is OK", pnum); |
| - bitflips = !!err; |
| + bitflips |= !!err; |
| } |
| mutex_unlock(&ubi->buf_mutex); |
| |
