| From 299d0c5b27346a77a0777c993372bf8777d4f2e5 Mon Sep 17 00:00:00 2001 |
| From: Brian Norris <computersforpeace@gmail.com> |
| Date: Sat, 28 Feb 2015 02:23:28 -0800 |
| Subject: UBI: fix check for "too many bytes" |
| |
| From: Brian Norris <computersforpeace@gmail.com> |
| |
| commit 299d0c5b27346a77a0777c993372bf8777d4f2e5 upstream. |
| |
| The comparison from the previous line seems to have been erroneously |
| (partially) copied-and-pasted onto the next. The second line should be |
| checking req.bytes, not req.lnum. |
| |
| Coverity CID #139400 |
| |
| Signed-off-by: Brian Norris <computersforpeace@gmail.com> |
| [rw: Fixed comparison] |
| Signed-off-by: Richard Weinberger <richard@nod.at> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/mtd/ubi/cdev.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/mtd/ubi/cdev.c |
| +++ b/drivers/mtd/ubi/cdev.c |
| @@ -455,7 +455,7 @@ static long vol_cdev_ioctl(struct file * |
| /* Validate the request */ |
| err = -EINVAL; |
| if (req.lnum < 0 || req.lnum >= vol->reserved_pebs || |
| - req.bytes < 0 || req.lnum >= vol->usable_leb_size) |
| + req.bytes < 0 || req.bytes > vol->usable_leb_size) |
| break; |
| |
| err = get_exclusive(desc); |
