| From 562b103a21974c2f9cd67514d110f918bb3e1796 Mon Sep 17 00:00:00 2001 |
| From: Marek Vasut <marex@denx.de> |
| Date: Fri, 30 Oct 2015 13:48:19 +0100 |
| Subject: can: Use correct type in sizeof() in nla_put() |
| |
| From: Marek Vasut <marex@denx.de> |
| |
| commit 562b103a21974c2f9cd67514d110f918bb3e1796 upstream. |
| |
| The sizeof() is invoked on an incorrect variable, likely due to some |
| copy-paste error, and this might result in memory corruption. Fix this. |
| |
| Signed-off-by: Marek Vasut <marex@denx.de> |
| Cc: Wolfgang Grandegger <wg@grandegger.com> |
| Cc: netdev@vger.kernel.org |
| Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/net/can/dev.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/net/can/dev.c |
| +++ b/drivers/net/can/dev.c |
| @@ -915,7 +915,7 @@ static int can_fill_info(struct sk_buff |
| nla_put(skb, IFLA_CAN_BITTIMING_CONST, |
| sizeof(*priv->bittiming_const), priv->bittiming_const)) || |
| |
| - nla_put(skb, IFLA_CAN_CLOCK, sizeof(cm), &priv->clock) || |
| + nla_put(skb, IFLA_CAN_CLOCK, sizeof(priv->clock), &priv->clock) || |
| nla_put_u32(skb, IFLA_CAN_STATE, state) || |
| nla_put(skb, IFLA_CAN_CTRLMODE, sizeof(cm), &cm) || |
| nla_put_u32(skb, IFLA_CAN_RESTART_MS, priv->restart_ms) || |
