| From 98da62b716a3b24ab8e77453c9a8a954124c18cd Mon Sep 17 00:00:00 2001 |
| From: Stewart Smith <stewart@linux.vnet.ibm.com> |
| Date: Fri, 11 Dec 2015 12:08:23 +1100 |
| Subject: powerpc/powernv: pr_warn_once on unsupported OPAL_MSG type |
| |
| From: Stewart Smith <stewart@linux.vnet.ibm.com> |
| |
| commit 98da62b716a3b24ab8e77453c9a8a954124c18cd upstream. |
| |
| When running on newer OPAL firmware that supports sending extra |
| OPAL_MSG types, we would print a warning on *every* message received. |
| |
| This could be a problem for kernels that don't support OPAL_MSG_OCC |
| on machines that are running real close to thermal limits and the |
| OCC is throttling the chip. For a kernel that is paying attention to |
| the message queue, we could get these notifications quite often. |
| |
| Conceivably, future message types could also come fairly often, |
| and printing that we didn't understand them 10,000 times provides |
| no further information than printing them once. |
| |
| Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> |
| Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| arch/powerpc/platforms/powernv/opal.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/arch/powerpc/platforms/powernv/opal.c |
| +++ b/arch/powerpc/platforms/powernv/opal.c |
| @@ -358,7 +358,7 @@ static void opal_handle_message(void) |
| |
| /* Sanity check */ |
| if (type >= OPAL_MSG_TYPE_MAX) { |
| - pr_warning("%s: Unknown message type: %u\n", __func__, type); |
| + pr_warn_once("%s: Unknown message type: %u\n", __func__, type); |
| return; |
| } |
| opal_message_do_notify(type, (void *)&msg); |