| From 37995116fecfce2b61ee3da6e73b3e394c6818f9 Mon Sep 17 00:00:00 2001 |
| From: Daniel Jurgens <danielj@mellanox.com> |
| Date: Thu, 10 Nov 2016 11:30:54 +0200 |
| Subject: IB/mlx4: Check gid_index return value |
| |
| From: Daniel Jurgens <danielj@mellanox.com> |
| |
| commit 37995116fecfce2b61ee3da6e73b3e394c6818f9 upstream. |
| |
| Check the returned GID index value and return an error if it is invalid. |
| |
| Fixes: 5070cd2239bd ('IB/mlx4: Replace mechanism for RoCE GID management') |
| Signed-off-by: Daniel Jurgens <danielj@mellanox.com> |
| Reviewed-by: Mark Bloch <markb@mellanox.com> |
| Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com> |
| Signed-off-by: Leon Romanovsky <leon@kernel.org> |
| Signed-off-by: Doug Ledford <dledford@redhat.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/infiniband/hw/mlx4/ah.c | 5 ++++- |
| 1 file changed, 4 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/infiniband/hw/mlx4/ah.c |
| +++ b/drivers/infiniband/hw/mlx4/ah.c |
| @@ -102,7 +102,10 @@ static struct ib_ah *create_iboe_ah(stru |
| if (vlan_tag < 0x1000) |
| vlan_tag |= (ah_attr->sl & 7) << 13; |
| ah->av.eth.port_pd = cpu_to_be32(to_mpd(pd)->pdn | (ah_attr->port_num << 24)); |
| - ah->av.eth.gid_index = mlx4_ib_gid_index_to_real_index(ibdev, ah_attr->port_num, ah_attr->grh.sgid_index); |
| + ret = mlx4_ib_gid_index_to_real_index(ibdev, ah_attr->port_num, ah_attr->grh.sgid_index); |
| + if (ret < 0) |
| + return ERR_PTR(ret); |
| + ah->av.eth.gid_index = ret; |
| ah->av.eth.vlan = cpu_to_be16(vlan_tag); |
| if (ah_attr->static_rate) { |
| ah->av.eth.stat_rate = ah_attr->static_rate + MLX4_STAT_RATE_OFFSET; |
