| From 6bdf131fac2336adb1a628f992ba32384f653a55 Mon Sep 17 00:00:00 2001 |
| From: Josef Bacik <jbacik@fb.com> |
| Date: Fri, 2 Sep 2016 15:25:43 -0400 |
| Subject: Btrfs: don't leak reloc root nodes on error |
| |
| From: Josef Bacik <jbacik@fb.com> |
| |
| commit 6bdf131fac2336adb1a628f992ba32384f653a55 upstream. |
| |
| We don't track the reloc roots in any sort of normal way, so the only way the |
| root/commit_root nodes get free'd is if the relocation finishes successfully and |
| the reloc root is deleted. Fix this by free'ing them in free_reloc_roots. |
| Thanks, |
| |
| Signed-off-by: Josef Bacik <jbacik@fb.com> |
| Signed-off-by: David Sterba <dsterba@suse.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/btrfs/relocation.c | 4 ++++ |
| 1 file changed, 4 insertions(+) |
| |
| --- a/fs/btrfs/relocation.c |
| +++ b/fs/btrfs/relocation.c |
| @@ -2366,6 +2366,10 @@ void free_reloc_roots(struct list_head * |
| while (!list_empty(list)) { |
| reloc_root = list_entry(list->next, struct btrfs_root, |
| root_list); |
| + free_extent_buffer(reloc_root->node); |
| + free_extent_buffer(reloc_root->commit_root); |
| + reloc_root->node = NULL; |
| + reloc_root->commit_root = NULL; |
| __del_reloc_root(reloc_root); |
| } |
| } |
