| From 578620f451f836389424833f1454eeeb2ffc9e9f Mon Sep 17 00:00:00 2001 |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| Date: Sat, 10 Dec 2016 09:56:01 -0500 |
| Subject: ext4: return -ENOMEM instead of success |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| commit 578620f451f836389424833f1454eeeb2ffc9e9f upstream. |
| |
| We should set the error code if kzalloc() fails. |
| |
| Fixes: 67cf5b09a46f ("ext4: add the basic function for inline data support") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Theodore Ts'o <tytso@mit.edu> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| fs/ext4/inline.c | 4 +++- |
| 1 file changed, 3 insertions(+), 1 deletion(-) |
| |
| --- a/fs/ext4/inline.c |
| +++ b/fs/ext4/inline.c |
| @@ -336,8 +336,10 @@ static int ext4_update_inline_data(handl |
| |
| len -= EXT4_MIN_INLINE_DATA_SIZE; |
| value = kzalloc(len, GFP_NOFS); |
| - if (!value) |
| + if (!value) { |
| + error = -ENOMEM; |
| goto out; |
| + } |
| |
| error = ext4_xattr_ibody_get(inode, i.name_index, i.name, |
| value, len); |