| From stable-bounces@linux.kernel.org Mon Feb 5 04:48:48 2007 |
| From: Tejun Heo <htejun@gmail.com> |
| Date: Mon, 5 Feb 2007 21:47:13 +0900 |
| Subject: ide: fix drive side 80c cable check |
| To: Alan <alan@lxorguk.ukuu.org.uk> |
| Cc: linux-ide@vger.kernel.org, stable@kernel.org, bzolnier@gmail.com |
| Message-ID: <20070205124713.GL1625@htj.dyndns.org> |
| Content-Disposition: inline |
| |
| |
| eighty_ninty_three() had word 93 validitity check but not the 80c bit |
| test itself (bit 12). This increases the chance of incorrect wire |
| detection especially because host side cable detection is often |
| unreliable and we sometimes soley depend on drive side cable |
| detection. Fix it. |
| |
| Signed-off-by: Tejun Heo <htejun@gmail.com> |
| Acked-by: Alan <alan@lxorguk.ukuu.org.uk> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| drivers/ide/ide-iops.c | 2 ++ |
| 1 file changed, 2 insertions(+) |
| |
| --- linux-2.6.20.1.orig/drivers/ide/ide-iops.c |
| +++ linux-2.6.20.1/drivers/ide/ide-iops.c |
| @@ -607,6 +607,8 @@ u8 eighty_ninty_three (ide_drive_t *driv |
| if(!(drive->id->hw_config & 0x4000)) |
| return 0; |
| #endif /* CONFIG_IDEDMA_IVB */ |
| + if (!(drive->id->hw_config & 0x2000)) |
| + return 0; |
| return 1; |
| } |
| |
