| From kaber@trash.net Thu Oct 23 13:16:08 2008 |
| From: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> |
| Date: Wed, 22 Oct 2008 19:41:29 +0200 (MEST) |
| Subject: netfilter: snmp nat leaks memory in case of failure |
| To: stable@kernel.org |
| Cc: netfilter-devel@vger.kernel.org, Patrick McHardy <kaber@trash.net>, davem@davemloft.net |
| Message-ID: <20081022174129.21341.93881.sendpatchset@x2.localnet> |
| |
| From: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> |
| |
| netfilter: snmp nat leaks memory in case of failure |
| |
| Upstream commit 311670f3e: |
| |
| Signed-off-by: Ilpo Jarvinen <ilpo.jarvinen@helsinki.fi> |
| Signed-off-by: Patrick McHardy <kaber@trash.net> |
| |
| --- |
| net/ipv4/netfilter/nf_nat_snmp_basic.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| --- a/net/ipv4/netfilter/nf_nat_snmp_basic.c |
| +++ b/net/ipv4/netfilter/nf_nat_snmp_basic.c |
| @@ -742,6 +742,7 @@ static unsigned char snmp_object_decode( |
| *obj = kmalloc(sizeof(struct snmp_object) + len, |
| GFP_ATOMIC); |
| if (*obj == NULL) { |
| + kfree(p); |
| kfree(id); |
| if (net_ratelimit()) |
| printk("OOM in bsalg (%d)\n", __LINE__); |
